Test json schema (#2861)

* Add unit test for service form build * Add tests for submit
airbytehq · Apr 15, 2021 · e0c7609 · e0c7609
1 parent 4f20ac7
commit e0c7609
Show file tree

Hide file tree

Showing 12 changed files with 670 additions and 193 deletions.
diff --git a/airbyte-webapp/package-lock.json b/airbyte-webapp/package-lock.json
diff --git a/airbyte-webapp/package.json b/airbyte-webapp/package.json
@@ -44,9 +44,9 @@
     "yup": "^0.28.1"
   },
   "devDependencies": {
-    "@testing-library/jest-dom": "^4.2.4",
-    "@testing-library/react": "^9.3.2",
-    "@testing-library/user-event": "^7.1.2",
+    "@testing-library/jest-dom": "^5.11.4",
+    "@testing-library/react": "^11.1.0",
+    "@testing-library/user-event": "^12.1.10",
     "@types/flat": "^5.0.1",
     "@types/jest": "^24.0.0",
     "@types/json-schema": "^7.0.6",

diff --git a/airbyte-webapp/src/components/ArrayOfObjectsEditor/ArrayOfObjectsEditor.tsx b/airbyte-webapp/src/components/ArrayOfObjectsEditor/ArrayOfObjectsEditor.tsx
@@ -62,7 +62,11 @@ const ArrayOfObjectsEditor: React.FC<ArrayOfObjectsEditorProps> = ({
           <SmallButton onClick={onCancelEdit} type="button" secondary>
             <FormattedMessage id="form.cancel" />
           </SmallButton>
-          <SmallButton onClick={onDone} type="button">
+          <SmallButton
+            onClick={onDone}
+            type="button"
+            data-test-id="done-button"
+          >
             <FormattedMessage id="form.done" />
           </SmallButton>
         </ButtonContainer>

diff --git a/airbyte-webapp/src/components/ArrayOfObjectsEditor/components/EditorHeader.tsx b/airbyte-webapp/src/components/ArrayOfObjectsEditor/components/EditorHeader.tsx
@@ -28,7 +28,12 @@ const EditorHeader: React.FC<EditorHeaderProps> = ({
   return (
     <Content>
       <FormattedMessage id="form.items" values={{ count: itemsCount }} />
-      <Button secondary type="button" onClick={onAddItem}>
+      <Button
+        secondary
+        type="button"
+        onClick={onAddItem}
+        data-test-id="addItemButton"
+      >
         <FormattedMessage id="form.addItems" />
       </Button>
     </Content>

diff --git a/airbyte-webapp/src/components/Multiselect/Multiselect.tsx b/airbyte-webapp/src/components/Multiselect/Multiselect.tsx
@@ -5,6 +5,7 @@ import { MultiselectProps as WidgetMultiselectProps } from "react-widgets/lib/Mu
 type MultiselectProps = {
   disabled?: boolean;
   error?: boolean;
+  name?: string;
 } & WidgetMultiselectProps;
 
 const Multiselect = styled(ReactMultiselect)<MultiselectProps>`