Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test json schema #2861

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Test json schema #2861

merged 4 commits into from
Apr 15, 2021

Conversation

jamakase
Copy link
Contributor

What

Closes #2561

@jamakase jamakase requested a review from cgardens April 12, 2021 23:16
@jamakase jamakase self-assigned this Apr 12, 2021
@jamakase jamakase changed the title Jamakase/test json schema Test json schema Apr 12, 2021
@sherifnada sherifnada removed their request for review April 12, 2021 23:26
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's also worth it to test the case of a oneOf with one option that is an object with empty properties?

@jamakase
Copy link
Contributor Author

Do you think it's also worth it to test the case of a oneOf with one option that is an object with empty properties?

Actually in this case we will just send either an empty object or won't send the field at all depending whether we changed this field or not. We discussed with @cgardens some time ago that omitting the field with empty object is actually the same as not sending object at all. It is not that easy to support other behaviour for our forms because of the way how Formik library works.

@jamakase jamakase merged commit e0c7609 into master Apr 15, 2021
@jamakase jamakase deleted the jamakase/test-json-schema branch April 15, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for "complex" json schema specs
2 participants