Skip to content

Commit

Permalink
🚨🚨 Source linkedin ads: Migrate to May 2023 (#26372)
Browse files Browse the repository at this point in the history
* Source LinkedIn Ads: update CDK version

* Source LinkedIn Ads: update schemas

* Source LinkedIn Ads: refactor source

* Source LinkedIn Ads: Migrate to May 2023

* Source LinkedIn Ads: monkeypatch url encoding to bypass encode :,%()

* Source LinkedIn Ads: fix test

* Source LinkedIn Ads: fix unittest

* Source Pinterest: refactor

* Source LinkedIn Ads: update docstrings; Refactor

* Source LinkedIn Ads: bump version

* Source LinkedIn Ads: update docs

* Source LinkedIn Ads: update schemas

* Automated Change

* Source LinkedIn Ads: update schemas; refactor

* Source LinkedIn Ads: update expected records

* Source LinkedIn Ads: refactor

* Source LinkedIn Ads: fix unit test

* Source LinkedIn Ads: fix acceptance test config

* Source LinkedIn Ads: update source

* Source LinkedIn Ads: update abnormal state

* Source LinkedIn Ads: add TypeTransformer + fix schema

* Source LinkedIn Ads: Format code

* Source LinkedIn Ads: update expected records

* Source LinkedIn Ads: update expected records

* Source LinkedIn Ads: update doc links

* Source LinkedIn Ads: pin CDK version

* Source LinkedIn Ads: refactor;
pass already encoded request params

* Source LinkedIn Ads: fix acceptance test versioning

---------

Co-authored-by: artem1205 <artem1205@users.noreply.github.com>
  • Loading branch information
artem1205 and artem1205 committed May 30, 2023
1 parent 462316b commit e3076e6
Show file tree
Hide file tree
Showing 22 changed files with 941 additions and 631 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ COPY source_linkedin_ads ./source_linkedin_ads
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.16
LABEL io.airbyte.version=0.2.0
LABEL io.airbyte.name=airbyte/source-linkedin-ads
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ acceptance_tests:
discovery:
tests:
- config_path: "secrets/config_oauth.json"
backward_compatibility_tests_config:
disable_for_version: 0.1.16 # migration to May 2023 Api Version; schema changes; stream removed
timeout_seconds: 60
basic_read:
tests:
- config_path: "secrets/config_oauth.json"
expect_records:
path: "integration_tests/expected_records.txt"
path: "integration_tests/expected_records.jsonl"
fail_on_extra_columns: false
incremental:
tests:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
{
"type": "STREAM",
"stream": {
"stream_state": { "lastModified": "2050-01-01" },
"stream_state": { "lastModifiedAt": 2524608000000 },
"stream_descriptor": { "name": "creatives" }
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,10 @@
"json_schema": {},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["lastModified"]
"default_cursor_field": ["lastModifiedAt"]
},
"sync_mode": "incremental",
"cursor_field": ["lastModified"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ad_direct_sponsored_contents",
"json_schema": {},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["lastModified"]
},
"sync_mode": "incremental",
"cursor_field": ["lastModified"],
"cursor_field": ["lastModifiedAt"],
"destination_sync_mode": "append"
},
{
Expand Down

Large diffs are not rendered by default.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ data:
connectorType: source
definitionId: 137ece28-5434-455c-8f34-69dc3782f451
maxSecondsBetweenMessages: 21600
dockerImageTag: 0.1.16
dockerImageTag: 0.2.0
dockerRepository: airbyte/source-linkedin-ads
githubIssueLabel: source-linkedin-ads
icon: linkedin.svg
Expand Down
3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-linkedin-ads/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.1",
"pendulum~=2.1",
"airbyte-cdk~=0.37",
]

TEST_REQUIREMENTS = [
Expand Down

0 comments on commit e3076e6

Please sign in to comment.