🐛Source Asana: Fix order of authentication methods (#26653)

* Fix the order of authentication methods to make OAuth default one * Add allowedHosts to metadata.yaml
airbytehq · May 30, 2023 · 462316b · 462316b
1 parent c5a58fe
commit 462316b
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 22 deletions.
diff --git a/airbyte-integrations/connectors/source-asana/Dockerfile b/airbyte-integrations/connectors/source-asana/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.5
+LABEL io.airbyte.version=0.1.6
 LABEL io.airbyte.name=airbyte/source-asana
diff --git a/airbyte-integrations/connectors/source-asana/metadata.yaml b/airbyte-integrations/connectors/source-asana/metadata.yaml
@@ -1,8 +1,11 @@
 data:
+  allowedHosts:
+    hosts:
+      - app.asana.com
   connectorSubtype: api
   connectorType: source
   definitionId: d0243522-dccf-4978-8ba0-37ed47a0bdbf
-  dockerImageTag: 0.1.5
+  dockerImageTag: 0.1.6
   dockerRepository: airbyte/source-asana
   githubIssueLabel: source-asana
   icon: asana.svg

diff --git a/airbyte-integrations/connectors/source-asana/source_asana/spec.json b/airbyte-integrations/connectors/source-asana/source_asana/spec.json
@@ -11,25 +11,6 @@
         "description": "Choose how to authenticate to Github",
         "type": "object",
         "oneOf": [
-          {
-            "type": "object",
-            "title": "Authenticate with Personal Access Token",
-            "required": ["personal_access_token"],
-            "properties": {
-              "option_title": {
-                "type": "string",
-                "title": "Credentials title",
-                "description": "PAT Credentials",
-                "const": "PAT Credentials"
-              },
-              "personal_access_token": {
-                "type": "string",
-                "title": "Personal Access Token",
-                "description": "Asana Personal Access Token (generate yours <a href=\"https://app.asana.com/0/developer-console\">here</a>).",
-                "airbyte_secret": true
-              }
-            }
-          },
           {
             "type": "object",
             "title": "Authenticate via Asana (Oauth)",
@@ -60,6 +41,25 @@
                 "airbyte_secret": true
               }
             }
+          },
+          {
+            "type": "object",
+            "title": "Authenticate with Personal Access Token",
+            "required": ["personal_access_token"],
+            "properties": {
+              "option_title": {
+                "type": "string",
+                "title": "Credentials title",
+                "description": "PAT Credentials",
+                "const": "PAT Credentials"
+              },
+              "personal_access_token": {
+                "type": "string",
+                "title": "Personal Access Token",
+                "description": "Asana Personal Access Token (generate yours <a href=\"https://app.asana.com/0/developer-console\">here</a>).",
+                "airbyte_secret": true
+              }
+            }
           }
         ]
       }
@@ -68,7 +68,7 @@
   "authSpecification": {
     "auth_type": "oauth2.0",
     "oauth2Specification": {
-      "rootObject": ["credentials", 1],
+      "rootObject": ["credentials", 0],
       "oauthFlowInitParameters": [["client_id"], ["client_secret"]],
       "oauthFlowOutputParameters": [["refresh_token"]]
     }

diff --git a/docs/integrations/sources/asana.md b/docs/integrations/sources/asana.md
@@ -68,6 +68,7 @@ The connector is restricted by normal Asana [requests limitation](https://develo
 
 | Version | Date       | Pull Request                                             | Subject                                                    |
 | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- |
+| 0.1.6   | 2023-05-26 | [26653](https://github.com/airbytehq/airbyte/pull/26653) | Fix order of authentication methods                        |
 | 0.1.5   | 2022-11-16 | [19561](https://github.com/airbytehq/airbyte/pull/19561) | Added errors handling, updated SAT with new format         |
 | 0.1.4   | 2022-08-18 | [15749](https://github.com/airbytehq/airbyte/pull/15749) | Add cache to project stream                                |
 | 0.1.3   | 2021-10-06 | [6832](https://github.com/airbytehq/airbyte/pull/6832)   | Add oauth init flow parameters support                     |