Always surface normalization failure reason (#20025)

airbytehq · Dec 2, 2022 · e7789cb · e7789cb
1 parent 764496e
commit e7789cb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...e-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java b/...e-commons-worker/src/main/java/io/airbyte/workers/general/DefaultNormalizationWorker.java
@@ -80,25 +80,25 @@ public NormalizationSummary run(final NormalizationInput input, final Path jobRo
       }
     } catch (final Exception e) {
       ApmTraceUtils.addExceptionToTrace(e);
+      LOGGER.error("Normalization failed for job {}.", jobId, e);
       buildFailureReasonsAndSetFailure();
     }
 
     if (cancelled.get()) {
-      LOGGER.info("Normalization was cancelled.");
+      LOGGER.info("Normalization was cancelled for job {}.", jobId);
     }
 
     final long endTime = System.currentTimeMillis();
     final Duration duration = Duration.ofMillis(endTime - startTime);
     final String durationDescription = DurationFormatUtils.formatDurationWords(duration.toMillis(), true, true);
-    LOGGER.info("Normalization executed in {}.", durationDescription);
+    LOGGER.info("Normalization executed in {} for job {}.", durationDescription, jobId);
 
     final NormalizationSummary summary = new NormalizationSummary()
         .withStartTime(startTime)
         .withEndTime(endTime);
 
     if (!traceFailureReasons.isEmpty()) {
       summary.setFailures(traceFailureReasons);
-      LOGGER.error("Normalization Failed.");
     } else if (failed) {
       throw new WorkerException("Normalization Failed.");
     }