Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always surface normalization failure reason #20025

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Always surface normalization failure reason #20025

merged 1 commit into from
Dec 2, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Improve visibility into normalization failure reasons

How

  • Surface the underlying exception when normalization fails in log messages

Recommended reading order

  1. DefaultNormalizationWorker.java

Tests

  • All tests pass
  • Project builds successfully

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 2, 2022 16:17 Inactive
@jdpgrailsdev jdpgrailsdev merged commit e7789cb into master Dec 2, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/surface-normalization-failures branch December 2, 2022 17:02
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdpgrailsdev @cgardens