Skip to content

Commit

Permalink
馃帀 Source Bing Ads: added undeclared fields to schemas (#25668)
Browse files Browse the repository at this point in the history 
* added undeclared fields to schemas

* updated changelog

* bump version in metadata

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
@darynaishchenko @octavia-squidington-iii
darynaishchenko and octavia-squidington-iii committed May 5, 2023
1 parent eab7795 commit f946052
Show file tree
Hide file tree
Showing 12 changed files with 71 additions and 29 deletions.
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9985,7 +9985,7 @@
"sourceDefinitionId": "47f25999-dd5e-4636-8c39-e7cea2453331",
"name": "Bing Ads",
"dockerRepository": "airbyte/source-bing-ads",
"dockerImageTag": "0.1.20",
"dockerImageTag": "0.1.21",
"documentationUrl": "https://docs.airbyte.com/integrations/sources/bing-ads",
"icon": "bingads.svg",
"sourceType": "api",
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
- name: Bing Ads
sourceDefinitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerRepository: airbyte/source-bing-ads
dockerImageTag: 0.1.20
dockerImageTag: 0.1.21
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
icon: bingads.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@
- "overwrite"
- "append"
- "append_dedup"
- dockerImage: "airbyte/source-bing-ads:0.1.20"
- dockerImage: "airbyte/source-bing-ads:0.1.21"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/bing-ads"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.20
LABEL io.airbyte.version=0.1.21
LABEL io.airbyte.name=airbyte/source-bing-ads
1 change: 0 additions & 1 deletion airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ acceptance_tests:
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: keyword_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
fail_on_extra_columns: false
full_refresh:
tests:
- config_path: secrets/config.json
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/metadata.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 0.1.20
dockerImageTag: 0.1.21
dockerRepository: airbyte/source-bing-ads
githubIssueLabel: source-bing-ads
icon: bingads.svg
Expand Down
3 changes: 3 additions & 0 deletions ...ations/connectors/source-bing-ads/source_bing_ads/schemas/account_performance_report.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@
"Conversions": {
"type": ["null", "number"]
},
"ConversionsQualified":{
"type": ["null", "number"]
},
"ConversionRate": {
"type": ["null", "number"]
},
Expand Down
21 changes: 21 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas/accounts.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,27 @@
"AccountMode": {
"type": ["null", "string"]
},
"ForwardCompatibilityMap": {
"type": ["null", "string"]
},
"PaymentMethodType": {
"type": ["null", "string"]
},
"Language": {
"type": ["null", "string"]
},
"LinkedAgencies": {
"type": ["null", "string"]
},
"TaxInformation": {
"type": ["null", "string"]
},
"CurrencyCode": {
"type": ["null", "string"]
},
"TimeZone": {
"type": ["null", "string"]
},
"BusinessAddress": {
"type": ["null", "object"],
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions ...tions/connectors/source-bing-ads/source_bing_ads/schemas/campaign_performance_report.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@
"AllConversions": {
"type": ["null", "integer"]
},
"ConversionsQualified": {
"type": ["null", "number"]
},
"AllConversionRate": {
"type": ["null", "number"]
},
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas/campaigns.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"BudgetType": {
"type": ["null", "string"]
},
"MultimediaAdsBidAdjustment": {
"type": ["null", "number"]
},
"DailyBudget": {
"type": ["null", "number"]
},
Expand Down
12 changes: 12 additions & 0 deletions ...ations/connectors/source-bing-ads/source_bing_ads/schemas/keyword_performance_report.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@
"KeywordStatus": {
"type": ["null", "string"]
},
"HistoricalExpectedCtr": {
"type": ["null", "number"]
},
"HistoricalAdRelevance": {
"type": ["null", "number"]
},
"HistoricalLandingPageExperience": {
"type": ["null", "number"]
},
"HistoricalQualityScore": {
"type": ["null", "number"]
},
"Impressions": {
"type": ["null", "integer"]
},
Expand Down
47 changes: 24 additions & 23 deletions docs/integrations/sources/bing-ads.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,26 +102,27 @@ A report's aggregation window is indicated in its name. For example, `account_pe
The Bing Ads API limits the number of requests for all Microsoft Advertising clients. You can find detailed info [here](https://docs.microsoft.com/en-us/advertising/guides/services-protocol?view=bingads-13#throttling).

## Changelog
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------|
| 0.1.20 | 2023-03-09 | [23663](https://github.com/airbytehq/airbyte/pull/23663) | Add lookback window for performance reports in incremental mode |
| 0.1.19 | 2023-03-08 | [23868](https://github.com/airbytehq/airbyte/pull/23868) | Add dimensional-type columns for reports. |
| 0.1.18 | 2023-01-30 | [22073](https://github.com/airbytehq/airbyte/pull/22073) | Fix null values in the `Keyword` column of `keyword_performance_report` streams |
| 0.1.17 | 2022-12-10 | [20005](https://github.com/airbytehq/airbyte/pull/20005) | Add `Keyword` to `keyword_performance_report` stream |
| 0.1.16 | 2022-10-12 | [17873](https://github.com/airbytehq/airbyte/pull/17873) | Fix: added missing campaign types in (Audience, Shopping and DynamicSearchAds) in campaigns stream |
| 0.1.15 | 2022-10-03 | [17505](https://github.com/airbytehq/airbyte/pull/17505) | Fix: limit cache size for ServiceClient instances |
| 0.1.14 | 2022-09-29 | [17403](https://github.com/airbytehq/airbyte/pull/17403) | Fix: limit cache size for ReportingServiceManager instances |
| 0.1.13 | 2022-09-29 | [17386](https://github.com/airbytehq/airbyte/pull/17386) | Migrate to per-stream states. |
| 0.1.12 | 2022-09-05 | [16335](https://github.com/airbytehq/airbyte/pull/16335) | Added backoff for socket.timeout |
| 0.1.11 | 2022-08-25 | [15684](https://github.com/airbytehq/airbyte/pull/15684) (published in [15987](https://github.com/airbytehq/airbyte/pull/15987)) | Fixed log messages being unreadable |
| 0.1.10 | 2022-08-12 | [15602](https://github.com/airbytehq/airbyte/pull/15602) | Fixed bug caused Hourly Reports to crash due to invalid fields set |
| 0.1.9 | 2022-08-02 | [14862](https://github.com/airbytehq/airbyte/pull/14862) | Added missing columns |
| 0.1.8 | 2022-06-15 | [13801](https://github.com/airbytehq/airbyte/pull/13801) | All reports `hourly/daily/weekly/monthly` will be generated by default, these options are removed from input configuration |
| 0.1.7 | 2022-05-17 | [12937](https://github.com/airbytehq/airbyte/pull/12937) | Added OAuth2.0 authentication method, removed `redirect_uri` from input configuration |
| 0.1.6 | 2022-04-30 | [12500](https://github.com/airbytehq/airbyte/pull/12500) | Improve input configuration copy |
| 0.1.5 | 2022-01-01 | [11652](https://github.com/airbytehq/airbyte/pull/11652) | Rebump attempt after DockerHub failure at registring the 0.1.4 |
| 0.1.4 | 2022-03-22 | [11311](https://github.com/airbytehq/airbyte/pull/11311) | Added optional Redirect URI & Tenant ID to spec |
| 0.1.3 | 2022-01-14 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Fixed broken dependency that blocked connector's operations |
| 0.1.2 | 2021-12-14 | [8429](https://github.com/airbytehq/airbyte/pull/8429) | Update titles and descriptions |
| 0.1.1 | 2021-08-31 | [5750](https://github.com/airbytehq/airbyte/pull/5750) | Added reporting streams\) |
| 0.1.0 | 2021-07-22 | [4911](https://github.com/airbytehq/airbyte/pull/4911) | Initial release supported core streams \(Accounts, Campaigns, Ads, AdGroups\) |
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------------------------------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------|
| 0.1.21 | 2023-04-28 | [25668](https://github.com/airbytehq/airbyte/pull/25668) | Add undeclared fields to accounts, campaigns, campaign_performance_report, keyword_performance_report and account_performance_report streams |
| 0.1.20 | 2023-03-09 | [23663](https://github.com/airbytehq/airbyte/pull/23663) | Add lookback window for performance reports in incremental mode |
| 0.1.19 | 2023-03-08 | [23868](https://github.com/airbytehq/airbyte/pull/23868) | Add dimensional-type columns for reports. |
| 0.1.18 | 2023-01-30 | [22073](https://github.com/airbytehq/airbyte/pull/22073) | Fix null values in the `Keyword` column of `keyword_performance_report` streams |
| 0.1.17 | 2022-12-10 | [20005](https://github.com/airbytehq/airbyte/pull/20005) | Add `Keyword` to `keyword_performance_report` stream |
| 0.1.16 | 2022-10-12 | [17873](https://github.com/airbytehq/airbyte/pull/17873) | Fix: added missing campaign types in (Audience, Shopping and DynamicSearchAds) in campaigns stream |
| 0.1.15 | 2022-10-03 | [17505](https://github.com/airbytehq/airbyte/pull/17505) | Fix: limit cache size for ServiceClient instances |
| 0.1.14 | 2022-09-29 | [17403](https://github.com/airbytehq/airbyte/pull/17403) | Fix: limit cache size for ReportingServiceManager instances |
| 0.1.13 | 2022-09-29 | [17386](https://github.com/airbytehq/airbyte/pull/17386) | Migrate to per-stream states. |
| 0.1.12 | 2022-09-05 | [16335](https://github.com/airbytehq/airbyte/pull/16335) | Added backoff for socket.timeout |
| 0.1.11 | 2022-08-25 | [15684](https://github.com/airbytehq/airbyte/pull/15684) (published in [15987](https://github.com/airbytehq/airbyte/pull/15987)) | Fixed log messages being unreadable |
| 0.1.10 | 2022-08-12 | [15602](https://github.com/airbytehq/airbyte/pull/15602) | Fixed bug caused Hourly Reports to crash due to invalid fields set |
| 0.1.9 | 2022-08-02 | [14862](https://github.com/airbytehq/airbyte/pull/14862) | Added missing columns |
| 0.1.8 | 2022-06-15 | [13801](https://github.com/airbytehq/airbyte/pull/13801) | All reports `hourly/daily/weekly/monthly` will be generated by default, these options are removed from input configuration |
| 0.1.7 | 2022-05-17 | [12937](https://github.com/airbytehq/airbyte/pull/12937) | Added OAuth2.0 authentication method, removed `redirect_uri` from input configuration |
| 0.1.6 | 2022-04-30 | [12500](https://github.com/airbytehq/airbyte/pull/12500) | Improve input configuration copy |
| 0.1.5 | 2022-01-01 | [11652](https://github.com/airbytehq/airbyte/pull/11652) | Rebump attempt after DockerHub failure at registring the 0.1.4 |
| 0.1.4 | 2022-03-22 | [11311](https://github.com/airbytehq/airbyte/pull/11311) | Added optional Redirect URI & Tenant ID to spec |
| 0.1.3 | 2022-01-14 | [9510](https://github.com/airbytehq/airbyte/pull/9510) | Fixed broken dependency that blocked connector's operations |
| 0.1.2 | 2021-12-14 | [8429](https://github.com/airbytehq/airbyte/pull/8429) | Update titles and descriptions |
| 0.1.1 | 2021-08-31 | [5750](https://github.com/airbytehq/airbyte/pull/5750) | Added reporting streams\) |
| 0.1.0 | 2021-07-22 | [4911](https://github.com/airbytehq/airbyte/pull/4911) | Initial release supported core streams \(Accounts, Campaigns, Ads, AdGroups\) |

0 comments on commit f946052

Please sign in to comment.