Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Bing Ads: added undeclared fields to schemas #25668

Merged
merged 6 commits into from
May 5, 2023

Conversation

darynaishchenko
Copy link
Collaborator

Added undeclared fields to accounts, campaigns, campaign_performance_report, keyword_performance_report and account_performance_report streams

@darynaishchenko darynaishchenko self-assigned this Apr 28, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads labels Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko darynaishchenko changed the title Source Bing Ads: added undeclared fields to schemas 🎉 Source Bing Ads: added undeclared fields to schemas Apr 28, 2023
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Apr 28, 2023

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4831671630
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4831671630
🐛

@darynaishchenko darynaishchenko linked an issue Apr 28, 2023 that may be closed by this pull request
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 2, 2023

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4858555372
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4858555372
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      142     16    89%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           515     48    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 37 passed, 2 skipped in 533.14s (0:08:53) ===================

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 4, 2023

/publish connector=connectors/source-bing-ads

🕑 Publishing the following connectors:
connectors/source-bing-ads
https://github.com/airbytehq/airbyte/actions/runs/4884421998


Connector Version Did it publish? Were definitions generated?
connectors/source-bing-ads 0.1.21

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 4, 2023

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4884557185
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4884557185
🐛 https://gradle.com/s/36e2ckmbilybu

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 ERROR unit_tests/test_client.py - AttributeError: module 'urllib3.connectionp...
	 ERROR unit_tests/test_reports.py - AttributeError: module 'urllib3.connection...
	 ERROR unit_tests/test_source.py - AttributeError: module 'urllib3.connectionp...
	 !!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
	 �[31m============================== �[31m�[1m3 errors�[0m�[31m in 3.39s�[0m�[31m ===============================�[0m

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 5, 2023

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4891663539
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4891663539
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      142     16    89%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           515     48    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 37 passed, 2 skipped in 560.00s (0:09:19) ===================

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented May 5, 2023

/publish connector=connectors/source-bing-ads

🕑 Publishing the following connectors:
connectors/source-bing-ads
https://github.com/airbytehq/airbyte/actions/runs/4891873202


Connector Version Did it publish? Were definitions generated?
connectors/source-bing-ads 0.1.21

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@darynaishchenko darynaishchenko merged commit f946052 into master May 5, 2023
21 of 22 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-bing-ads/24924-improvment branch May 5, 2023 10:00
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* added undeclared fields to schemas

* updated changelog

* bump version in metadata

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/bing-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Bing Ads: Add undeclared columns to spec
3 participants