Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FB Marketing API v10 #2230

Closed
sherifnada opened this issue Feb 26, 2021 · 1 comment · Fixed by #2391
Closed

Support FB Marketing API v10 #2230

sherifnada opened this issue Feb 26, 2021 · 1 comment · Fixed by #2391
Assignees
@yevhenii-ldv
Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Milestone
Connectors 03-19-...

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

For a user to use Airbyte's FB connector, they need to create a FB app. Access tokens generated from FB Apps can only be used with the latest API version present at the time of creating the FB app.

Facebook just released v10 of the marketing API, and a user just reported being unable to use the FB connector since their app only supports v10.

We should upgrade to FB marketing API v10 so we do not have this issue. We should verify that apps were initialized on older API versions will not be impacted.
@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues zazmic labels Feb 26, 2021
@yevhenii-ldv
Copy link
Contributor

Scoping report:

At the moment, the facebook-business library (which we use to work with Facebook Marketing) version 10.0.0 is already available, which supports the Graph version 10.
Referring to the link, the updates should not have an impact on the previous API (unless it may slightly affect the Ads Insights API, this will need to be rechecked).

Also, these changes will need to be applied to the Instagram connector, I will do it today while working on the task: Source Instagram: Ensure best practices

Approximate estimate for updating the library version and retesting all Facebook Marketing streams: 3h

@sherifnada sherifnada added this to the Connectors 03-19-2021 milestone Mar 5, 2021
@yevhenii-ldv yevhenii-ldv self-assigned this Mar 10, 2021
yevhenii-ldv pushed a commit that referenced this issue Mar 10, 2021
#2230 Issue: update facebook_business version to 10.0.0 with Graph AP…
a1d2805 
…I v10
yevhenii-ldv pushed a commit that referenced this issue Mar 10, 2021
#2230 Issue: bumping version of facebook-marketing
7544550
@keu keu linked a pull request Mar 12, 2021 that will close this issue
🎉 Support FB Marketing API v10 #2391
Merged
2 tasks
@keu keu closed this as completed in #2391 Mar 12, 2021
keu pushed a commit that referenced this issue Mar 12, 2021
@yevhenii-ldv
🎉 Support FB Marketing API v10 (#2391)
2a4c1e3 
* #2230 Issue: update facebook_business version to 10.0.0 with Graph API v10

* #2230 Issue: bumping version of facebook-marketing

Co-authored-by: ykurochkin <y.kurochkin@zazmic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevhenii-ldv yevhenii-ldv

Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Projects
None yet
Milestone
Connectors 03-19-2021
Development

Successfully merging a pull request may close this issue.

🎉 Support FB Marketing API v10 airbytehq/airbyte
3 participants
@sherifnada @karinakuz @yevhenii-ldv