Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connector CI to report status to Github Status Checks not comments #29300

Closed
evantahler opened this issue Aug 9, 2023 · 5 comments · Fixed by #31871
Closed

Update Connector CI to report status to Github Status Checks not comments #29300

evantahler opened this issue Aug 9, 2023 · 5 comments · Fixed by #31871
Assignees

Comments

@evantahler
Copy link
Contributor

evantahler commented Aug 9, 2023

Some connector developers are wary of pushing often to Github because CI spams comments onto their PRs, especially if you are working on multiple connectors. This makes seeing PR reviews and comments hard.

Right now, CI leaves both a comment and a Github Status check (1,2) for every test (from #29213)

Screenshot 2023-08-09 at 12 13 17 PM Screenshot 2023-08-09 at 12 13 13 PM

Now that we have excellent CI reports (e.g.), I believe that the need for the Github comment is less than it used to be. We should change the URL in the Github status to point to this report, rather than the action. This gives the connector developer the information they need to investigate a failure, without clogging up the PR history.

If we cannot change the status report URL, then we should be updating the existing CI comment rather than making a new one. This would serve the same goal of spam reduction.

@pedroslopez
Copy link
Contributor

pedroslopez commented Aug 15, 2023

grooming:

  • Rename Connectors CI to Connectors CI (trigger)
  • Connectors CI (trigger) details -> stick to going to the github action run
  • Connectors CI tests details -> Dagger Cloud
  • Individual test step details -> HTML report
  • HTML report continually updated upon step start/completion
    • Q: how do logs fit into the continuously updated report?
  • Check status for individual test step should go red immediately upon a failure
  • Kill the PR comment

@alafanechere
Copy link
Contributor

Moving this to the Connectors CI/CD new features as the task force is over.

@bnchrch bnchrch changed the title Connectors CI should not leave comments Update Connector CI to report status to Github Status Checks not comments Aug 23, 2023
@evantahler
Copy link
Contributor Author

I'd like to bring this back as part of the DX work we are doing in Q4 if there's time (cc @bnchrch / @alafanechere ). It's still rather annoying to get an email/slack for every test run

@evantahler
Copy link
Contributor Author

Grooming:

  • Remove the comments
  • Update the GHA per-connector status links to point to a new root HTML report that links to all the sub-connector builds

@alafanechere
Copy link
Contributor

alafanechere commented Oct 26, 2023

I disable test reports in comments in PR #31871 .
I'll opened a different issue (#31872) to create global html reports.
It's a bit more complex to implement currently because we don't have a GlobalContext , reports are attached to PipelineContext that are per connector. PipelineContexts are not attached to a higher level object that can gather all of them (and their reports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants