-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Connector CI to report status to Github Status Checks not comments #29300
Comments
grooming:
|
Moving this to the Connectors CI/CD new features as the task force is over. |
I'd like to bring this back as part of the DX work we are doing in Q4 if there's time (cc @bnchrch / @alafanechere ). It's still rather annoying to get an email/slack for every test run |
Grooming:
|
I disable test reports in comments in PR #31871 . |
Some connector developers are wary of pushing often to Github because CI spams comments onto their PRs, especially if you are working on multiple connectors. This makes seeing PR reviews and comments hard.
Right now, CI leaves both a comment and a Github Status check (1,2) for every test (from #29213)
Now that we have excellent CI reports (e.g.), I believe that the need for the Github comment is less than it used to be. We should change the URL in the Github status to point to this report, rather than the action. This gives the connector developer the information they need to investigate a failure, without clogging up the PR history.
If we cannot change the status report URL, then we should be updating the existing CI comment rather than making a new one. This would serve the same goal of spam reduction.
The text was updated successfully, but these errors were encountered: