airbyte-ci: disable test reports PR comments #31871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
octavia-squidington-iii
added
area/connectors
bnchrch
approved these changes
Oct 26, 2023
| @@ -25,6 +25,8 @@ | |||
| class ConnectorReport(Report): | |||
| """A dataclass to build connector test reports to share pipelines executions results with the user.""" | |||
|
|
|||
| ENABLE_PR_COMMENTS: bool = False | |||
There was a problem hiding this comment.
Im a bit apprehensive of leaving unused code in the code base.
Code is cattle not a pet (ref)
I would argue that we remove it, unless theres a reason to keep it around that I may be missing.
There was a problem hiding this comment.
When we will consider running the CI on community PRs I think having these comments back can be a good way to expose high-level results to the community contributors. HTML reports are currently private to not overly expose logs.
alafanechere
force-pushed
the
augustin/10-26-airbyte-ci_disable_test_reports_PR_comments
branch
from
8547b87
to
775117a
Compare
This reverts commit dee797b.
alafanechere
deleted the
augustin/10-26-airbyte-ci_disable_test_reports_PR_comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #29300
We don't want PR comments anymore on connector CI test run.
How
The global Connector CI status details will link to the GHA workflow.
The per connector status details will link to the GHA workflow while they're running and to the HTML report when they're done.
Why a 'feature flag' instead of deleting the commenting logic
When we will consider running the CI on community PRs I think having these comments back can be a good way to expose high-level results to the community contributors. HTML reports are currently private to not overly expose logs.