Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITAS] Integration tests for all empty streams in source-stripe #32871

Closed
2 tasks
maxi297 opened this issue Nov 28, 2023 · 1 comment
Closed
2 tasks

[ITAS] Integration tests for all empty streams in source-stripe #32871

maxi297 opened this issue Nov 28, 2023 · 1 comment
Assignees

Comments

@maxi297
Copy link
Contributor

maxi297 commented Nov 28, 2023

In order to gain confidence in the change for concurrent CDK incremental, we want to add a layer of tests before performing the change. Those tests should validate the HTTP requests that are performed, the number of records returned by the source and the state value for full refresh and incremental syncs. Those tests should be implemented for all the empty streams i.e.:

  • application_fees (IncrementalStripeStream)
  • application_fees_refunds (UpdatedCursorIncrementalStripeLazySubStream)
  • authorizations (IncrementalStripeStream)
  • bank_accounts (UpdatedCursorIncrementalStripeLazySubStream)
  • cards (IncrementalStripeStream)
  • early_fraud_warnings (UpdatedCursorIncrementalStripeStream)
  • external_account_bank_accounts (UpdatedCursorIncrementalStripeStream)
  • external_account_cards (UpdatedCursorIncrementalStripeStream)
  • payment_methods (UpdatedCursorIncrementalStripeStream)
  • persons (Persons) extracted to [ITAS] source-stripe - persons #33348
  • reviews (IncrementalStripeStream)
  • transactions (IncrementalStripeStream)
  • events (Events)

Given that this does not inflate the scope of the issue too much, it would be interesting to explore the different ways to generate mocked responses i.e.

  • From an actual response (we might have some data on the events streams
  • From the API documentation
  • From the OpenAPI spec
    If we could have a very high level estimation of that is the easiest way and what work would be needed to make it work, that would be fantastic!

Blocked by:

Acceptance Criteria

  • All empty streams are covered
  • Many devs have implemented tests
@maxi297 maxi297 self-assigned this Dec 7, 2023
maxi297 added a commit that referenced this issue Dec 18, 2023
@maxi297
Copy link
Contributor Author

maxi297 commented Dec 21, 2023

User impacting things discovered while doing integration tests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant