[ISSUE #32869] response builder #32983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxi297
commented
Nov 30, 2023
girarda
approved these changes
Dec 1, 2023
airbyte-cdk/python/unit_tests/test/http/test_response_builder.py
Outdated
Show resolved
Hide resolved
bazarnov
approved these changes
Dec 1, 2023
maxi297
added a commit
that referenced
this pull request
Dec 5, 2023
… builder (#32983) Co-authored-by: octavia-approvington <octavia-approvington@users.noreply.github.com>
rishabh-cldcvr
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Dec 14, 2023
…airbytehq#32869] response builder (airbytehq#32983) Co-authored-by: octavia-approvington <octavia-approvington@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses #32869
How
Creating builders that are both sourced from a template file.
Adding utils method to create those builders and extract the content of a template file
Recommended reading order
airbyte-cdk/python/airbyte_cdk/test/http/response_builder.py🚨 User Impact 🚨
None until it is used in #32871