Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Amazon Ads: add integration tests #34260

Closed
roman-yermilov-gl opened this issue Jan 15, 2024 · 0 comments · Fixed by #34476
Closed

Source Amazon Ads: add integration tests #34260

roman-yermilov-gl opened this issue Jan 15, 2024 · 0 comments · Fixed by #34476
Assignees
@roman-yermilov-gl
Labels
connectors/source/amazon-ads team/connectors-python

Comments

@roman-yermilov-gl
Copy link
Contributor

roman-yermilov-gl commented Jan 15, 2024 •
edited
Loading

Relevant information

Integration tests need to be added to this connector since we have 13 streams without expected records.

The type of assertions we are aiming for described here.
The process to create responses described here.

Example of already implemented tests for Stripe: #33306.
@roman-yermilov-gl roman-yermilov-gl changed the title Copy of Source Amazon Seller Partner: add integration tests Source Amazon Ads: add integration tests Jan 15, 2024
@roman-yermilov-gl roman-yermilov-gl linked a pull request Jan 24, 2024 that will close this issue
Source Amazon Ads: integration tests for empty streams #34476
Merged
@roman-yermilov-gl roman-yermilov-gl mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
connectors/source/amazon-ads team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Source Amazon Ads: integration tests for empty streams airbytehq/airbyte
3 participants
@marcosmarxm @askarpets @roman-yermilov-gl