-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Amazon Ads: integration tests for empty streams #34476
Source Amazon Ads: integration tests for empty streams #34476
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@roman-yermilov-gl Please add missing empty streams to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstrings for test with a detailed description of what we are testing and why
3e5be8e
to
16eebb0
Compare
What
The issue: #34260
Adding integration tests for source amazon ads to cover reports/sponsored/attribution streams
How
Cover streams defined as empty in
acceptance-test-config.yaml
with integraion testsRecommended reading order
unit_tests/integrations/*.py
unit_tests/integrations/resource/http/response/*.json