Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinations supporting refreshes: Resuming truncate refresh incorrectly skips T+D if the resumed sync emits no records #41036

Closed
1 task done
edgao opened this issue Jul 8, 2024 · 0 comments · Fixed by #41041
Labels

Comments

@edgao
Copy link
Contributor

edgao commented Jul 8, 2024

Connector Name

destination-bigquery + destination-snowflake

Connector Version

2.8.1

What step the error happened?

During the sync

Relevant information

example:

  1. Attempt 1 of a truncate refresh emits 10 records, then crashes without emitting a stream COMPLETE status. We write these to a temp raw table, and skip T+D.
  2. Attempt 2 emits 0 records. This check will skip T+D.
  3. We then overwrite the final table with an empty final table.

to fix: truncate syncs should also check the temp raw table initial status for whether there were preexisting records.

Relevant log output

No response

Contribute

  • Yes, I want to contribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants