Destination Bigquery+Snowflake: Fix resuming truncate refresh #41041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
stephane-airbyte
approved these changes
Jul 8, 2024
...rc/main/kotlin/io/airbyte/integrations/base/destination/operation/AbstractStreamOperation.kt
Show resolved
Hide resolved
johnny-schmidt
approved these changes
Jul 8, 2024
| (!streamSuccessful || | ||
| (syncSummary.recordsWritten == 0L && | ||
| !(initialRawTableStatus.rawTableExists && | ||
| initialRawTableStatus.hasUnprocessedRecords))) |
There was a problem hiding this comment.
Alright, I think I understand: before if we crashed and started again but had no more records, we'd incorrectly interpret that as there being no intermediate state. This clarifies: we need both 0 new records AND the tmp table not to exist.
There was a problem hiding this comment.
yep. tried to capture that in the comment :/ but this is definitely an ugly conditional
|
/publish-java-cdk
|
octavia-squidington-iii
added
the
area/documentation
edgao
commented
Jul 8, 2024
| @@ -223,7 +223,8 @@ tutorials: | |||
|
|
|||
| | Version | Date | Pull Request | Subject | | |||
| |:--------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | 2.8.1 | 2024-06-25 | [39379](https://github.com/airbytehq/airbyte/pull/38331) | Removing requirement of a redundant permission bigquery.datasets.create permission | | |||
| | 2.8.2 | 2024-07-08 | [41041](https://github.com/airbytehq/airbyte/pull/41041) | Fix resume logic in truncate refreshes to prevent data loss | | |||
| | 2.8.1 | 2024-06-25 | [39379](https://github.com/airbytehq/airbyte/pull/39379) | Removing requirement of a redundant permission bigquery.datasets.create permission | | |||
There was a problem hiding this comment.
(fixing a copypasta error in the url - no other changes in this line)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #41036