Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Workload launcher has duplicate entries in container envs #43432

Closed
film42 opened this issue Aug 9, 2024 · 4 comments
Closed

[platform] Workload launcher has duplicate entries in container envs #43432

film42 opened this issue Aug 9, 2024 · 4 comments
Assignees
Labels
area/platform issues related to the platform community team/platform-move type/bug Something isn't working

Comments

@film42
Copy link

film42 commented Aug 9, 2024

Helm Chart Version

0.414.0

What step the error happened?

Upgrading the Platform or Helm Chart

Relevant information

Only thing I changed was the helm chart version. I was previously on 0.242.2 . In airbyte versions I was upgrading from 0.63.3 to 0.63.14.

The errors is:

      .spec.template.spec.containers[name="airbyte-workload-launcher-container"].env: duplicate entries for key [name="JOB_MAIN_CONTAINER_CPU_REQUEST"]
      .spec.template.spec.containers[name="airbyte-workload-launcher-container"].env: duplicate entries for key [name="JOB_MAIN_CONTAINER_CPU_LIMIT"]
      .spec.template.spec.containers[name="airbyte-workload-launcher-container"].env: duplicate entries for key [name="JOB_MAIN_CONTAINER_MEMORY_REQUEST"]
      .spec.template.spec.containers[name="airbyte-workload-launcher-container"].env: duplicate entries for key [name="JOB_MAIN_CONTAINER_MEMORY_LIMIT"]

Duplicates without conditionals defined here: https://github.com/airbytehq/airbyte-platform/blob/v0.63.14/charts/airbyte-workload-launcher/templates/deployment.yaml#L229-L323

Looks like this error happened because of the switch from airbyte server to the workload launcher and new api service.

I asked in slack but didn't get any feedback. Figured I'd open a ticket: https://airbytehq.slack.com/archives/C021JANJ6TY/p1723157877530959

Relevant log output

No response

@marcosmarxm
Copy link
Member

Thanks for reporting the issue @film42. Is this only a warning message or stopping the server pod to start?
cc @airbytehq/platform-move

@marcosmarxm marcosmarxm changed the title Workload launcher has duplicate entries in container envs [platform] Workload launcher has duplicate entries in container envs Aug 10, 2024
@film42
Copy link
Author

film42 commented Aug 11, 2024

It fails to apply the change to the kube api.

@davinchia davinchia self-assigned this Aug 13, 2024
octavia-squidington-iii pushed a commit to airbytehq/airbyte-platform that referenced this issue Aug 13, 2024
From airbytehq/airbyte#43432, fix the duplicate env vars. Looks like the result of a bad merge.
@davinchia davinchia reopened this Aug 13, 2024
@davinchia
Copy link
Contributor

Hi, we've removed the duplicate env vars as of 0.429.0. I tested and this should be working fine now. Let me know if you have any more questions!

@film42
Copy link
Author

film42 commented Aug 17, 2024

Works for me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community team/platform-move type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants