Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sendgrid connector should take a human-readable date rather than an integer timestamp #4842

Closed
sherifnada opened this issue Jul 19, 2021 · 1 comment · Fixed by #16400
Closed

Sendgrid connector should take a human-readable date rather than an integer timestamp #4842

sherifnada opened this issue Jul 19, 2021 · 1 comment · Fixed by #16400
Assignees
@davydov-d
Labels
area/connectors Connector related issues connectors/source/sendgrid connectors/sources-api lang/python priority/low Low priority team/connectors-python type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Jul 19, 2021 •
edited
Loading

Tell us about the problem you're trying to solve

the sendgrid source connector takes as input for replication start date an integer timestamp.

Describe the solution you’d like

a more usable date string e.g: full or partial ISO formatted string. This must also be backwards compatible with the integer timestamp to avoid breaking any existing users of sendgrid.
@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues lang/python priority/low Low priority labels Jul 19, 2021
davydov-d added a commit that referenced this issue Sep 7, 2022
@davydov-d
#4842 Source Sendgrid: change start time param type to datetime string
83b935f
@davydov-d
Copy link
Collaborator

#16400
could not link the PR in a proper input field

@davydov-d davydov-d linked a pull request Sep 7, 2022 that will close this issue
Source Sendgrid: change start time param type to datetime string #16400
Merged
davydov-d added a commit that referenced this issue Sep 7, 2022
@davydov-d
#4842 source sendgrid: upd changelog
ebc04b4
davydov-d added a commit that referenced this issue Sep 8, 2022
@davydov-d
#4842 source sendgrid: fix SAT
369a1da
davydov-d added a commit that referenced this issue Sep 12, 2022
@davydov-d
Merge branch 'master' into ddavydov/#4842-source-sendgrid-change-star…
1af22e9 
…time-param-type-to-datetime
davydov-d added a commit that referenced this issue Sep 12, 2022
@davydov-d @octavia-squidington-iii
Source Sendgrid: change start time param type to datetime string (#16400
60888c2 
)

* #4842 Source Sendgrid: change start time param type to datetime string

* #4842 source sendgrid: upd changelog

* #4842 source sendgrid: fix SAT

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
robbinhan pushed a commit to robbinhan/airbyte that referenced this issue Sep 29, 2022
@davydov-d @octavia-squidington-iii @robbinhan
Source Sendgrid: change start time param type to datetime string (air…
de860e0 
…bytehq#16400)

* airbytehq#4842 Source Sendgrid: change start time param type to datetime string

* airbytehq#4842 source sendgrid: upd changelog

* airbytehq#4842 source sendgrid: fix SAT

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this issue Oct 31, 2022
@davydov-d @octavia-squidington-iii @jhammarstedt
Source Sendgrid: change start time param type to datetime string (air…
290d04b 
…bytehq#16400)

* airbytehq#4842 Source Sendgrid: change start time param type to datetime string

* airbytehq#4842 source sendgrid: upd changelog

* airbytehq#4842 source sendgrid: fix SAT

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@inesmarcal inesmarcal mentioned this issue Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davydov-d davydov-d

Labels
area/connectors Connector related issues connectors/source/sendgrid connectors/sources-api lang/python priority/low Low priority team/connectors-python type/enhancement New feature or request
Projects
GL Roadmap
Status: Backlog (unscoped)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Source Sendgrid: change start time param type to datetime string airbytehq/airbyte
4 participants
@bleonard @sherifnada @davydov-d @igrankova