Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sendgrid: change start time param type to datetime string #16400

Conversation

davydov-d
Copy link
Collaborator

What

Start Time in a spec should receive a human readable datetime string instead of timestamp

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 7, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 7, 2022

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3009015185
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3009015185
🐛 https://gradle.com/s/wwcggddexldxu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - source_...
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
=============== 2 failed, 28 passed, 1 error in 65.77s (0:01:05) ===============

super().__init__(**kwargs)
self._start_time = start_time or 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._start_time = int(pendulum.parse(self._start_time).timestamp()) if isinstance(self._start_time, str) else start_time or 0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to re-declare here, I believe.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 8, 2022

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3013549673
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3013549673
🐛 https://gradle.com/s/66q4jwfvdk4ik

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - source_...
=================== 1 failed, 30 passed in 85.93s (0:01:25) ====================

@davydov-d
Copy link
Collaborator Author

depends on #16429

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 12, 2022

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3035462318
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3035462318
🐛 https://gradle.com/s/ly6mriewreyyu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - source_...
=================== 1 failed, 30 passed in 68.98s (0:01:08) ====================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 12, 2022

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3035557619
✅ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/3035557619
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_sendgrid/__init__.py       2      0   100%
source_sendgrid/streams.py      161     18    89%
source_sendgrid/source.py        26      3    88%
-------------------------------------------------
TOTAL                           189     21    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

All Passed

@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 12, 2022

/publish connector=connectors/source-sendgrid

🕑 Publishing the following connectors:
connectors/source-sendgrid
https://github.com/airbytehq/airbyte/actions/runs/3035868279


Connector Did it publish? Were definitions generated?
connectors/source-sendgrid

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 60888c2 into master Sep 12, 2022
@davydov-d davydov-d deleted the ddavydov/#4842-source-sendgrid-change-startime-param-type-to-datetime branch September 12, 2022 10:21
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…bytehq#16400)

* airbytehq#4842 Source Sendgrid: change start time param type to datetime string

* airbytehq#4842 source sendgrid: upd changelog

* airbytehq#4842 source sendgrid: fix SAT

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…bytehq#16400)

* airbytehq#4842 Source Sendgrid: change start time param type to datetime string

* airbytehq#4842 source sendgrid: upd changelog

* airbytehq#4842 source sendgrid: fix SAT

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sendgrid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sendgrid connector should take a human-readable date rather than an integer timestamp
3 participants