Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a backend property for "completed first sync" #5884

Closed
jrhizor opened this issue Sep 7, 2021 · 1 comment
Closed

create a backend property for "completed first sync" #5884

jrhizor opened this issue Sep 7, 2021 · 1 comment
Assignees
@benmoriceau
Labels
area/platform issues related to the platform priority/high High priority type/enhancement New feature or request
Milestone
Platform 2021-12-02

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Sep 7, 2021

In order for us to show the 👍 / 👎 display on the frontend after completing the first sync, we need to expose the value to the frontend. We could do this by augmenting the user's response to include this property. We could do this at the user level and look it up at in their workspaces to ensure they've successfully completed a sync.
@jrhizor jrhizor added type/enhancement New feature or request priority/high High priority area/platform issues related to the platform area/frontend labels Sep 7, 2021
@jrhizor jrhizor mentioned this issue Sep 7, 2021
Closed
@jrhizor jrhizor added this to the Core 2021-09-15 milestone Sep 8, 2021
@jrhizor jrhizor mentioned this issue Sep 20, 2021
Closed
@cgardens cgardens assigned Phlair and unassigned jrhizor Sep 29, 2021
@Phlair Phlair removed their assignment Oct 14, 2021
@cgardens cgardens assigned Phlair and unassigned Phlair Oct 20, 2021
@benmoriceau benmoriceau mentioned this issue Nov 12, 2021
Merged
benmoriceau added a commit that referenced this issue Nov 18, 2021
@benmoriceau
Bmoric/complete first sync (#7832)
0d51742 
After a sync is completed, we tag all the workspace with related to this sync as having a first sync completed.

This will then be forwarded to the UI in another PR.

This is part of #5884
@benmoriceau
Copy link
Contributor

Fully merged, #8113 has been created as a follow up on the frontend part.

schlattk pushed a commit to schlattk/airbyte that referenced this issue Jan 4, 2022
@benmoriceau @schlattk
Bmoric/complete first sync (airbytehq#7832)
81dd6b5 
After a sync is completed, we tag all the workspace with related to this sync as having a first sync completed.

This will then be forwarded to the UI in another PR.

This is part of airbytehq#5884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmoriceau benmoriceau

Labels
area/platform issues related to the platform priority/high High priority type/enhancement New feature or request
Projects
None yet
Milestone
Platform 2021-12-02
Development

Successfully merging a pull request may close this issue.

add hasCompletedSync in web backend get workspace endpoint airbytehq/airbyte
4 participants
@jrhizor @benmoriceau @cgardens @Phlair