Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write SATs to verify that unsupported data types are not generated #9460

Closed
edgao opened this issue Jan 13, 2022 · 0 comments · Fixed by #9851
Closed

Write SATs to verify that unsupported data types are not generated #9460

edgao opened this issue Jan 13, 2022 · 0 comments · Fixed by #9851
Assignees

Comments

@edgao
Copy link
Contributor

edgao commented Jan 13, 2022

We don't want sources to generate streams that contain these types:

  • not (e.g. {"not": {"type": "string"}})
  • allOf (e.g. {"allOf": [{"type": "string", "maxLength": 5}, {"type": "string", "minLength": 1}]})

Write SAT(s) that run the discovery command and then check that the streams don't contain any of these types.

Run the new SAT(s) against all sources; for any sources which are not compliant, create an issue to fix it, then add the issue to the "Noncompliant sources" section in the epic (https://github.com/airbytehq/airbyte-internal-issues/issues/371).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants