Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: check for not allowed keywords allOf, not in connectors schema #9851

Merged
merged 7 commits into from
Jan 28, 2022
Merged

SAT: check for not allowed keywords allOf, not in connectors schema #9851

merged 7 commits into from
Jan 28, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jan 27, 2022 •
edited
Loading

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

According to new connector schema requirements, it's forbidden to use allOf and not keywords in JSON schema.
Add new SAT test which fails if such keywords are found in schema.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

@grubberr
test_defined_keyword_exist_in_schema added
531022d 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Jan 27, 2022
@grubberr grubberr linked an issue Jan 27, 2022 that may be closed by this pull request
Write SATs to verify that unsupported data types are not generated #9460
Closed
@grubberr
CHANGELOG.md updated
eb1d85f 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 27, 2022 19:53 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Jan 27, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1758181892
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1758181892

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2022 19:58 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 28, 2022 09:57 Inactive
@grubberr
unit_tests updated
fa3b2af 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 28, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761140626
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761140626

@grubberr grubberr temporarily deployed to more-secrets January 28, 2022 10:55 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 28, 2022 10:57 Inactive
@grubberr
Merge branch 'master' into grubberr/9460-restrict-jsonschema
9b469f0
@grubberr
bump version 0.1.44 -> 0.1.46
49b6690 
0.1.45 - wrongly pushed to docker hub

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 28, 2022 •
edited by github-actions bot
Loading

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761330325
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/1761330325
No Python unittests run

@grubberr grubberr temporarily deployed to more-secrets January 28, 2022 11:44 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 28, 2022 11:46 Inactive
@grubberr
down version back to 0.1.45
b72b72b 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 28, 2022 12:04 Inactive
@grubberr grubberr merged commit c8ee3f8 into master Jan 28, 2022
@grubberr grubberr deleted the grubberr/9460-restrict-jsonschema branch January 28, 2022 13:51
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antixar antixar antixar approved these changes

@midavadim midavadim Awaiting requested review from midavadim

Assignees

@grubberr grubberr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write SATs to verify that unsupported data types are not generated
3 participants
@grubberr @antixar @octavia-squidington-iii