-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track const config values in analytics #10120
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ef4ac97
first pass at const detection
edgao 768f791
handle const objects
edgao 013b391
test more complex const object
edgao e122671
refactor merge logic
edgao 0c9c75a
extract value conversion; comments
edgao 4bcdd77
slight tweak
edgao b07f0ad
slight tweak
edgao 38dfa8b
const_null test
edgao 18adb56
remove todo
edgao e92d67a
early returns
edgao 57646b9
slight tweak
edgao 83ef629
test additionalProperties
edgao b54bde6
slight tweak
edgao f3e8b8b
fix other tests
edgao c75f20d
format
edgao 139b87a
move into Jsons
edgao e74066d
handle additionalProperties
edgao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
airbyte-scheduler/persistence/src/main/resources/example_config_schema.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
{ | ||
"type": "object", | ||
"properties": { | ||
"username": { | ||
"type": "string" | ||
}, | ||
"password": { | ||
"type": "string" | ||
}, | ||
"has_ssl": { | ||
"type": "boolean" | ||
}, | ||
"empty_string": { | ||
"type": "string" | ||
}, | ||
"null_value": { | ||
"type": "null" | ||
}, | ||
"one_of": { | ||
"type": "object", | ||
"oneOf": [ | ||
{ | ||
"type": "object", | ||
"properties": { | ||
"type_key": { | ||
"const": "foo" | ||
}, | ||
"some_key": { | ||
"type": "integer" | ||
} | ||
} | ||
} | ||
] | ||
}, | ||
"const_object": { | ||
"const": { | ||
"sub_key": "bar", | ||
"sub_array": [1, 2, 3], | ||
"sub_object": { | ||
"sub_sub_key": "baz" | ||
} | ||
} | ||
}, | ||
"const_null": { | ||
"const": null | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth reporting the names of
additionalProperties
not declared in the schema instead of ignoring them?If we studied the metadata sent to segment on those, we could have a sense of what's missing in the connector specs maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized that I might as well just handle additionalProperties in a smarter way, can you take a look at this? e74066d#diff-8ef120819d2dd157a1e8d1838a49917772872273fefb9719b56aa303174581abL235-R261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!