Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook Marketing: add primary_key for all insights streams #10138

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Feb 7, 2022

What

Closes #6557.

How

Add primary_key for all insights streams.

🚨 User Impact 🚨

Are there any breaking changes?
No.

Pre-merge Checklist

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@Zirochkaa Zirochkaa self-assigned this Feb 7, 2022
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 7, 2022
@Zirochkaa Zirochkaa temporarily deployed to more-secrets February 7, 2022 07:24 Inactive
@Zirochkaa Zirochkaa changed the title Source Facebook Marketing: add primary_key for all insights streams 🎉 Source Facebook Marketing: add primary_key for all insights streams Feb 7, 2022
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Feb 7, 2022

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805119658
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805119658
🐛 https://gradle.com/s/h62rs2sp5w76a

@Zirochkaa Zirochkaa temporarily deployed to more-secrets February 7, 2022 07:29 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 7, 2022 07:30 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Feb 7, 2022

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805213763
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805213763
🐛 https://gradle.com/s/s6xi77r5nlela

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 7, 2022 08:00 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Feb 7, 2022

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805300065
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805300065
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_facebook_marketing/__init__.py        2      0   100%
source_facebook_marketing/api.py            75     17    77%
source_facebook_marketing/async_job.py      92     58    37%
source_facebook_marketing/common.py         37     11    70%
source_facebook_marketing/source.py        114     66    42%
source_facebook_marketing/streams.py       253     90    64%
------------------------------------------------------------
TOTAL                                      573    242    58%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_facebook_marketing/__init__.py        2      0   100%
source_facebook_marketing/api.py            75     18    76%
source_facebook_marketing/async_job.py      92      1    99%
source_facebook_marketing/common.py         37      1    97%
source_facebook_marketing/source.py        114     73    36%
source_facebook_marketing/streams.py       253     89    65%
------------------------------------------------------------
TOTAL                                      573    182    68%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets February 7, 2022 08:20 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 7, 2022 08:21 Inactive
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@bfe0c9a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5894fd9 differs from pull request most recent head 80a07aa. Consider uploading reports for the commit 80a07aa to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10138   +/-   ##
=========================================
  Coverage          ?   68.01%           
=========================================
  Files             ?        6           
  Lines             ?      569           
  Branches          ?        0           
=========================================
  Hits              ?      387           
  Misses            ?      182           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe0c9a...80a07aa. Read the comment docs.

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Feb 7, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805388441
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1805388441

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 7, 2022 08:43 Inactive
@Zirochkaa Zirochkaa merged commit 66137f6 into master Feb 7, 2022
@Zirochkaa Zirochkaa deleted the oleh/6557-add-primary_key-for-insights-streams branch February 7, 2022 08:59
@Zirochkaa Zirochkaa temporarily deployed to more-secrets February 7, 2022 09:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: declare PK for insights stream
3 participants