Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃帀 Source Facebook Marketing: add primary_key for all insights streams #10138

Merged
merged 4 commits into from
Feb 7, 2022
Merged

馃帀 Source Facebook Marketing: add primary_key for all insights streams #10138

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27e6ee0
6557 Add `primary_key` for all insights streams
Zirochkaa Feb 7, 2022
d634a94
6557 Update docs
Zirochkaa Feb 7, 2022
5894fd9
6557 Fix integration_tests
Zirochkaa Feb 7, 2022
80a07aa
6557 Bump connector's version
Zirochkaa Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.31
LABEL io.airbyte.version=0.2.32
LABEL io.airbyte.name=airbyte/source-facebook-marketing
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/integration_tests/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def test_streams_with_include_deleted(self, stream_name, deleted_id, config_with
assert deleted_records, f"{stream_name} stream should have deleted records returned"
assert is_specific_deleted_pulled, f"{stream_name} stream should have a deleted record with id={deleted_id}"

@pytest.mark.parametrize("stream_name, deleted_num", [("ads", 2), ("campaigns", 1), ("ad_sets", 1)])
@pytest.mark.parametrize("stream_name, deleted_num", [("ads", 2), ("campaigns", 3), ("ad_sets", 1)])
def test_streams_with_include_deleted_and_state(self, stream_name, deleted_num, config_with_include_deleted, configured_catalog, state):
"""Should ignore state because of include_deleted enabled"""
catalog = self.slice_catalog(configured_catalog, {stream_name})
Expand Down
2 changes: 1 addition & 1 deletion ...te-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ class AdsInsights(FBMarketingIncrementalStream):
"""doc: https://developers.facebook.com/docs/marketing-api/insights"""

cursor_field = "date_start"
primary_key = None
primary_key = ["account_id", "campaign_id", "adset_id", "ad_id"]

ALL_ACTION_ATTRIBUTION_WINDOWS = [
"1d_click",
Expand Down
11 changes: 6 additions & 5 deletions docs/integrations/sources/facebook-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
This Source is capable of syncing the following tables and their data:

* [AdSets](https://developers.facebook.com/docs/marketing-api/reference/ad-campaign#fields)
* [Ads](https://developers.facebook.com/docs/marketing-api/reference/adgroup#fields)
* [Ads](https://developers.facebook.com/docs/marketing-api/reference/adgroup#fields)
* [AdCreatives](https://developers.facebook.com/docs/marketing-api/reference/ad-creative#fields)
* [Campaigns](https://developers.facebook.com/docs/marketing-api/reference/ad-campaign-group#fields)
* [AdInsights](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/)
* [Campaigns](https://developers.facebook.com/docs/marketing-api/reference/ad-campaign-group#fields)
* [AdInsights](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/)

You can segment the AdInsights table into parts based on the following information. Each part will be synced as a separate table if normalization is enabled:

Expand All @@ -31,7 +31,7 @@ For more information, see the [Facebook Insights API documentation. ](https://de

1. Click `Authenticate your Facebook Marketing account`.
2. Enter your Account ID. Learn how to find it are [here](https://www.facebook.com/business/help/1492627900875762).
3. Enter a start date and your Insights settings.
3. Enter a start date and your Insights settings.
4. You're done.

## Getting Started \(Airbyte Open-Source\)
Expand Down Expand Up @@ -96,7 +96,8 @@ As a summary, custom insights allows to replicate only some fields, resulting in

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.2.31 | 2021-12-28 | [](https://github.com/airbytehq/airbyte/pull/) | Fixed videos stream format field incorrect type |
| 0.2.32 | 2022-01-07 | [10138](https://github.com/airbytehq/airbyte/pull/10138) | Add `primary_key` for all insights streams. |
| 0.2.31 | 2021-12-29 | [9138](https://github.com/airbytehq/airbyte/pull/9138) | Fixed videos stream format field incorrect type |
| 0.2.30 | 2021-12-20 | [8962](https://github.com/airbytehq/airbyte/pull/8962) | Added `asset_feed_spec` field to `ad creatives` stream |
| 0.2.29 | 2021-12-17 | [8649](https://github.com/airbytehq/airbyte/pull/8649) | Retrive ad_creatives image as data encoded |
| 0.2.28 | 2021-12-13 | [8742](https://github.com/airbytehq/airbyte/pull/8742) | Fix for schema generation related to "breakdown" fields |
Expand Down