Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook Marketing: Add AdAccount and Images stream implementation #10180

Merged
merged 9 commits into from
Feb 9, 2022

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Feb 8, 2022

What

#9842 - Facebook Marketing Source: Support "Replicate Incremental Deletes"
#9840 - Facebook Marketing Source: Add "Ad Account" stream
#6226 - Facebook Marketing Source: Add "Ad Image" stream

How

Added AdAccount and AdImage streams implementation.
Added to docs info about Incremental Deletes Sync.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@lazebnyi lazebnyi temporarily deployed to more-secrets February 8, 2022 13:10 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 8, 2022 13:12 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 8, 2022 13:16 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Feb 8, 2022

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1812541929
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1812541929
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_facebook_marketing/__init__.py        2      0   100%
source_facebook_marketing/api.py            75     17    77%
source_facebook_marketing/async_job.py      92     58    37%
source_facebook_marketing/common.py         37     11    70%
source_facebook_marketing/source.py        114     66    42%
source_facebook_marketing/streams.py       287    108    62%
------------------------------------------------------------
TOTAL                                      607    260    57%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_facebook_marketing/__init__.py        2      0   100%
source_facebook_marketing/api.py            75     18    76%
source_facebook_marketing/async_job.py      92      1    99%
source_facebook_marketing/common.py         37      1    97%
source_facebook_marketing/source.py        114     73    36%
source_facebook_marketing/streams.py       287    107    63%
------------------------------------------------------------
TOTAL                                      607    200    67%

@lazebnyi lazebnyi temporarily deployed to more-secrets February 8, 2022 13:33 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 8, 2022 13:35 Inactive
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments for schemas.

Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

several minor comments

@lazebnyi lazebnyi temporarily deployed to more-secrets February 9, 2022 11:56 Inactive
@lazebnyi lazebnyi requested a review from antixar February 9, 2022 12:28
@lazebnyi lazebnyi temporarily deployed to more-secrets February 9, 2022 12:29 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please publish your changes

@lazebnyi lazebnyi removed the request for review from midavadim February 9, 2022 13:13
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Feb 9, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1818224980
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1818224980

@lazebnyi lazebnyi marked this pull request as ready for review February 9, 2022 13:14
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 13:17 Inactive
@lazebnyi lazebnyi merged commit 2573fa1 into master Feb 9, 2022
@lazebnyi lazebnyi deleted the lazebnyi/9840-add-adaccount-and-images-streams branch February 9, 2022 13:26
@lazebnyi lazebnyi temporarily deployed to more-secrets February 9, 2022 13:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
4 participants