Upgrade plop in connector generators

[timroes]

What

This updates the plop version in the connector generator to the most recent version. This will solve a security advisory in the dependency ansi-regex (https://github.com/airbytehq/airbyte/security/dependabot/38). I've accidentally already dismissed the security advisory for this (since I was only checking in webapp).

Also the node version is increased to the latest LTS release.

The update of plop also brings in a new version of the text utils which cause the titlteCase utitlity we use in our templates to behave differently, and thus changed the scaffold output for all connectors.

Due to the problem in the gradle build file the destination scaffold output was never correctly checked (outputDir was wrong for this), thus there are more file changes, that are not caused by this PR, but simply by never being checked into in their previous PRs that changed them.

I've tried to check if the generator still works and it seems to be working fine for me, but would be happy if this could get another test from someone from the connectors team.

[tuliren]

Also we remove all scaffold connectors that were most likely accidentally connected in the past after running the connector test suite, which generated those folders (and didn't reliable delete them afterwards). Also I've added source-/destinations-scaffold to .gitignore so they won't accidentally be commited in the future.

This has been clarified in this thread. We do need these generated scaffold connectors, because this is how we test the generators and make sure they have the expected output.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@9e941f3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f8a574b differs from pull request most recent head 17619c4. Consider uploading reports for the commit 17619c4 to get more accurate results

@@            Coverage Diff            @@
##             master   airbytehq/airbyte#10578   +/-   ##
=========================================
  Coverage          ?   92.68%           
=========================================
  Files             ?        2           
  Lines             ?       41           
  Branches          ?        0           
=========================================
  Hits              ?       38           
  Misses            ?        3           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e941f3...17619c4. Read the comment docs.

[timroes]

The current failure is coming from Sonar Scan running the tests in the source-scaffold-java-jdbc connector. Those tests though are not meant to pass without any changes, since they will require a (nearly) fully working JDBC source, while our scaffolded connector is simply a stub. This will happen on any PR that changes the scaffolded generated code, and I think should not be fixed as part of this PR. I've created https://github.com/airbytehq/airbyte-internal-issues/issues/437 for this.

[timroes]

@tuliren @sherifnada would appreciate a look with the udpated description and comment if you'll find some time for it.

[tuliren]

Thanks for creating the issue about Sonar Scan.

[tuliren]

This is supposed to be in title case, and should not have hyphens in them, as showed in plop's README. Maybe this is changed in the latest plop release? But I don't see that in their changelog though. I think we need to try to fix this before merging.

[tuliren]

titleCase is imported from the title-case library:
https://github.com/plopjs/node-plop/blob/master/src/baked-in-helpers.js#L2

and this library has not been updated for a year:
https://www.npmjs.com/package/title-case

Really strange where the hyphen is coming from.

[timroes]

@tuliren Yes that's indeed by the change in plop. The previously used plop version 2.7.6 used node-plop in version (0.26.3) (see https://github.com/plopjs/plop/blob/v2.7.6/package-lock.json#L4569-L4570), which itself used title-case in the version 2.1.1. title-case@2.1.1 did actually remove hyphens in word (the names always had hyphens actually in them as passed in by plop), which you can see here.

The upgraded plop version uses node-plop in 0.30.0, which itself uses title-case in 3.0.3. title-case@3.0.3 though does not remove hyphens anymore: https://codesandbox.io/s/title-case-3-0-3-1k9p54, thus we'll see the hyphens plot has in the name.

In this new version the same transform is now called capitalCase, which is unfortunately not enabled in plop by default. If we want the same casing we need to register it as a custom function and switch all templates to use capitalCase instead of titleCase. I wasn't sure if it's important for us how that name is exactly written in the READMEs, I am fine with either solution. The current one will change the casing, and therefore touch the scaffold output, with the other option I'll need to touch all templates, and the plop config to register the functions, but therefore all the scaffold output will stay the same. Let me know which one you prefer more, please.

[tuliren]

Cool. Thanks for digging into this. I do think it's important to not introduce the hyphens, because those titles will be everywhere and hard to change. It's actually quite easy to replace titleCase with capitalCase. PR here: #10654

[tuliren]

@timroes, wait, actually I don't see the hyphen from title-case@3.0.3 in https://codesandbox.io/s/title-case-3-0-3-1k9p54

Are we seeing different output?

[timroes]

Sorry I accedentally saved that with capitalCase already the example, since I wanted to double check the correct method name. Now it's back to using titleCase also for the second string :)

[tuliren]

Got it. Right, I can see the hyphen now. Thanks.