Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Google Ads - Fix user location report schema and add to acceptance tests #10919

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Mar 7, 2022

What

Previously this stream was not tested in SATs. Add it to the catalog so that SATs attempt to fetch the data.

Also, the stream wasn't actually declared correctly. Fix a field type to make it pass tests (closes #11184)

@edgao edgao temporarily deployed to more-secrets March 7, 2022 16:56 Inactive
@edgao edgao temporarily deployed to more-secrets March 7, 2022 16:56 Inactive
@edgao
Copy link
Contributor Author

edgao commented Mar 7, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1946790915
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1946790915
🐛 https://gradle.com/s/3iwbsc2tkja4y
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >600.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1753.82s (0:29:13) =============

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1946790915
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1946790915
🐛 https://gradle.com/s/ubinyw7ivz5rg
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >600.0s
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 19 passed, 1 skipped in 1812.64s (0:30:12) =============

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 7, 2022
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 7, 2022 16:59 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets March 7, 2022 23:38 Inactive
@edgao edgao force-pushed the edgao/gads_acceptance_test branch from e21b0d5 to ab5b3bc Compare March 8, 2022 00:20
@edgao edgao temporarily deployed to more-secrets March 8, 2022 00:22 Inactive
@edgao edgao temporarily deployed to more-secrets March 8, 2022 00:22 Inactive
@edgao edgao force-pushed the edgao/gads_acceptance_test branch from ab5b3bc to f655725 Compare March 21, 2022 03:05
@edgao
Copy link
Contributor Author

edgao commented Mar 21, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2013900351
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2013900351
🐛 https://gradle.com/s/bgipfiribdbue
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 20 passed, 1 skipped in 1406.89s (0:23:26) =============

@edgao
Copy link
Contributor Author

edgao commented Mar 22, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2024842961
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2024842961
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 130     24    82%
source_google_ads/source.py                   73     24    67%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        348    108    69%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/streams.py                 130     11    92%
source_google_ads/google_ads.py               68      7    90%
source_google_ads/source.py                   73     19    74%
--------------------------------------------------------------
TOTAL                                        348     43    88%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 1788.84s (0:29:48) ==================

@edgao edgao marked this pull request as ready for review March 22, 2022 22:03
@edgao edgao requested a review from girarda March 22, 2022 22:04
@edgao edgao changed the title Source Google Ads - add acceptance test for user location report 🎉 Source Google Ads - Fix user location report schema and add to acceptance tests Mar 22, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 22, 2022
@edgao
Copy link
Contributor Author

edgao commented Mar 22, 2022

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2025467502
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2025467502

@edgao edgao temporarily deployed to more-secrets March 23, 2022 01:15 Inactive
@edgao edgao temporarily deployed to more-secrets March 23, 2022 01:15 Inactive
@edgao edgao merged commit abae829 into master Mar 23, 2022
@edgao edgao deleted the edgao/gads_acceptance_test branch March 23, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Ads: user_location_view.country_criterion_id has incorrect JSON schema
3 participants