-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Auto-Disable Failing Connections feature #11099
Merged
Merged
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
22f78d7
Add Disable Failing Connections feature
terencecho 96f7fe3
Rename and cleanup
terencecho 4ffe081
list jobs based off connection id
terencecho 2015a94
Move variables to env config and update unit tests
terencecho ff0046e
Fix env flag name
terencecho 814d314
Fix missing name changes
terencecho bacdf92
Add comments to unit test
terencecho 9e0c365
Address PR comments
terencecho a8028f4
Support multiple config types
terencecho 1be1ad5
Update unit tests
terencecho 63a3cf4
Remove the attemptId notion in the connectionManagerWorkflow (#10780)
benmoriceau 52ab967
Revert "Remove the attemptId notion in the connectionManagerWorkflow …
benmoriceau e751b0e
Revert "Revert "Remove the attemptId notion in the connectionManagerW…
benmoriceau bfce0a2
Revert "Revert "Revert "Remove the attemptId notion in the connection…
benmoriceau cba4117
Add Disable Failing Connections feature
terencecho 0cd1ba0
Rename and cleanup
terencecho fe7591a
Fix rebase
terencecho 89ddee3
only disable if first job is older than max days
terencecho f0e824e
Return boolean for activity
terencecho a4530e8
Return boolean for activity
terencecho b206a25
Add unit tests for ConnectionManagerWorkflow
terencecho a3a6f5d
Utilize object output for activity and ignore non success or failed runs
terencecho 36adc9f
Utilize object output for activity and ignore non success or failed runs
terencecho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,3 +91,4 @@ MAX_DISCOVER_WORKERS=5 | |
|
||
### FEATURE FLAGS ### | ||
NEW_SCHEDULER=false | ||
AUTO_DISABLE_FAILING_CONNECTIONS=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,4 +12,6 @@ public interface FeatureFlags { | |
|
||
boolean usesNewScheduler(); | ||
|
||
boolean autoDisablesFailingConnections(); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to cast as a VARCHAR?
scope = '?'
should be working (same with the config type).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was the convention since most of the other queries casted the scope, but just ran the unit tests without it and had no problems, so i'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misspoke earlier, looks like the convention is not to cast the scope. But
ConfigType
is normally casted.