🐛Source Facebook Marketing: user_tos_accepted is an object #11801

mdibaiee · 2022-04-07T14:22:35Z

What

Fixes user_tos_accepted to be an object, see issue #11800

How

Define user_tos_accepted with the same schema as tos_accepted

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

┆Issue is synchronized with this Monday item by Unito

alafanechere · 2022-04-13T16:54:48Z

Thank you @mdibaiee for this contribution. I will need a review from the connector team as this connector is GA. Could you please also bump the version of this connector in the Dockerfile and update the changelog if facebook-marketing.md?

alafanechere · 2022-04-13T16:55:03Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2162599503
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2162599503
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                              101     13    87%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            35     13    63%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         845    336    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/source.py                            35      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/api.py                              101     10    90%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         845     79    91%

mdibaiee · 2022-04-13T17:03:17Z

@alafanechere bumped the version and added changelog entry 👍🏽

alafanechere · 2022-04-14T16:39:03Z

/publish connector=connectors/source-facebook-marketing auto-bump-version=false

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2168448901
❌ Failed to publish connectors/source-facebook-marketing
🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2168448901
🚀 Successfully published connectors/source-facebook-marketing
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2168448901

mdibaiee mentioned this pull request Apr 7, 2022

Source Facebook Marketing: user_tos_accepted is an object, not number in the schema #11800

Closed

octavia-squidington-iii added the community label Apr 7, 2022

github-actions bot added the area/connectors Connector related issues label Apr 7, 2022

alafanechere self-assigned this Apr 13, 2022

source-facebook-marketing: user_tos_accepted is an object

188079a

mdibaiee force-pushed the 11800/user-tos-accepted branch from b1c38b3 to 188079a Compare April 13, 2022 17:02

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 13, 2022

lazebnyi self-requested a review April 14, 2022 09:48

lazebnyi approved these changes Apr 14, 2022

View reviewed changes

lazebnyi changed the title ~~source-facebook-marketing: user_tos_accepted is an object~~ 🐛Source Facebook Marketing: user_tos_accepted is an object Apr 14, 2022

lazebnyi linked an issue Apr 14, 2022 that may be closed by this pull request

Source Facebook Marketing: user_tos_accepted is an object, not number in the schema #11800

Closed

lazebnyi requested a review from alafanechere April 14, 2022 13:12

lazebnyi mentioned this pull request Apr 14, 2022

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

Merged

16 tasks

alafanechere added 2 commits April 14, 2022 15:59

bump source definitions

5dd37a5

Merge branch 'master' into 11800/user-tos-accepted

c0738d2

alafanechere mentioned this pull request Apr 14, 2022

Publish 11801 #12018

Closed

alafanechere temporarily deployed to more-secrets April 14, 2022 14:29 Inactive

update source specs

131e727

alafanechere merged commit 992d229 into airbytehq:master Apr 15, 2022

octavia-squidington-iii mentioned this pull request Apr 19, 2022

Bump Airbyte version from 0.36.0-alpha to 0.36.1-alpha #12148

Merged

suhomud pushed a commit that referenced this pull request May 23, 2022

🐛Source Facebook Marketing: user_tos_accepted is an object (#11801)

4c973ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Facebook Marketing: user_tos_accepted is an object #11801

🐛Source Facebook Marketing: user_tos_accepted is an object #11801

mdibaiee commented Apr 7, 2022 •

edited by sync-by-unito bot

Loading

alafanechere commented Apr 13, 2022

alafanechere commented Apr 13, 2022 •

edited by github-actions bot

Loading

mdibaiee commented Apr 13, 2022

alafanechere commented Apr 14, 2022 •

edited by github-actions bot

Loading

🐛Source Facebook Marketing: user_tos_accepted is an object #11801

🐛Source Facebook Marketing: user_tos_accepted is an object #11801

Conversation

mdibaiee commented Apr 7, 2022 • edited by sync-by-unito bot Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alafanechere commented Apr 13, 2022

alafanechere commented Apr 13, 2022 • edited by github-actions bot Loading

mdibaiee commented Apr 13, 2022

alafanechere commented Apr 14, 2022 • edited by github-actions bot Loading

mdibaiee commented Apr 7, 2022 •

edited by sync-by-unito bot

Loading

alafanechere commented Apr 13, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 14, 2022 •

edited by github-actions bot

Loading