Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 publish command: fix for version bumping multiple connectors in same PR #12397

Merged
merged 15 commits into from
Apr 27, 2022

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented Apr 27, 2022

What

#12276

How

add a pull from the current branch @ origin just before we add and commit the automated changes.

Notes

Doing some dummy bumping on connectors to test, choosing lesser used ones

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 27, 2022
@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

To run publish command with changes from this PR I have to run manually from actions page.

I'll manually link to comments below.

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

Faker publish

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2233561205
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

Openweather publish

🕑 connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233561104
🚀 Successfully published connectors/source-openweather
🚀 Auto-bumped version for connectors/source-openweather
✅ connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233561104

@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 13:56 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 13:56 Inactive
@airbytehq airbytehq deleted a comment from codecov bot Apr 27, 2022
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:02 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:02 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:05 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:05 Inactive
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Can we trigger multiple publish commands in parallel or shall we run publish command sequentially?

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@b16e13e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12397   +/-   ##
=========================================
  Coverage          ?   93.67%           
=========================================
  Files             ?        4           
  Lines             ?       79           
  Branches          ?        0           
=========================================
  Hits              ?       74           
  Misses            ?        5           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e13e...7051477. Read the comment docs.

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

@alafanechere for now it's still just one connector per publish command, but this minor fix should mean they can all run at the same time and still auto-bump successfully. (technically there is still a window of failure but it's very very small)

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

Not sure why faker failed to publish, going to bump openweather again and test alongside a different connector

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:17 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:17 Inactive
@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

apify

🕑 connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2233683393
🚀 Successfully published connectors/source-apify-dataset
❌ Couldn't auto-bump version for connectors/source-apify-dataset

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

openweather

🕑 connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233683134
🚀 Successfully published connectors/source-openweather
🚀 Auto-bumped version for connectors/source-openweather
✅ connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233683134

@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:22 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:22 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:24 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:24 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:36 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 14:36 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:42 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:42 Inactive
@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

apify

🕑 connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2233822072
🚀 Successfully published connectors/source-apify-dataset
🚀 Auto-bumped version for connectors/source-apify-dataset
✅ connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2233822072

@Phlair
Copy link
Contributor Author

Phlair commented Apr 27, 2022

openweather

🕑 connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233822305
🚀 Successfully published connectors/source-openweather
🚀 Auto-bumped version for connectors/source-openweather
✅ connectors/source-openweather https://github.com/airbytehq/airbyte/actions/runs/2233822305

@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:47 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 27, 2022 14:47 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 15:00 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 27, 2022 15:00 Inactive
@Phlair Phlair merged commit 7e1d95c into master Apr 27, 2022
@Phlair Phlair deleted the george/publish-multi-fix branch April 27, 2022 15:18
suhomud pushed a commit that referenced this pull request May 23, 2022
…e PR (#12397)

* add a git pull from origin master before commit auto changes

* dummy bump 2 connectors

* pull from current branch not master

* auto-bump connector version

* dummy bump 2 connectors

* revert faker bump

* auto-bump connector version

* better descript in changelog

* dummy bump... again

* commit first, then pull merge, then push

* auto-bump connector version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants