Adds a new string cloumn to configs for cron #12416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malikdiarra
previously requested changes
Apr 28, 2022
...va/io/airbyte/db/instance/configs/migrations/V0_36_3_001__AddScheduleTypeToConfigsTable.java
Outdated
Show resolved
Hide resolved
...va/io/airbyte/db/instance/configs/migrations/V0_36_3_001__AddScheduleTypeToConfigsTable.java
Outdated
Show resolved
Hide resolved
...va/io/airbyte/db/instance/configs/migrations/V0_36_3_001__AddScheduleTypeToConfigsTable.java
Outdated
Show resolved
Hide resolved
|
|
supertopher
force-pushed
the
toph-CRON-new-schedule-column
branch
from
7743156
to
7cb6428
Compare
closes #11418 i'm new to this task in Java please be brutal
supertopher
force-pushed
the
toph-CRON-new-schedule-column
branch
from
7cb6428
to
6e747c9
Compare
|
@davinchia I'm getting a pretty weird error on my branch when I try to run I'll look into the gradle now, but I'm getting rate limit errors on my docker hub account trying to compile the jooq. this error loops a few times a second (explaining the rate limit part anyway) at java.lang.Thread.run(Thread.java:833) [?:?]
2022-05-17 21:59:51 WARN o.t.i.RemoteDockerImage(resolve):104 - Retrying pull for image: testcontainers/ryuk:0.3.3 (118s remaining)
2022-05-17 21:59:51 ERROR c.g.d.a.a.ResultCallbackTemplate(onError):52 - Error during callback
com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"Head \"https://registry-1.docker.io/v2/testcontainers/ryuk/manifests/0.3.3\": toomanyrequests: too many failed login attempts for username or IP address"}
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247) ~[testcontainers-1.17.1.jar:?]
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269) ~[testcontainers-1.17.1.jar:?]
at java.lang.Thread.run(Thread.java:833) [?:?]
2022-05-17 21:59:51 WARN o.t.i.RemoteDockerImage(resolve):104 - Retrying pull for image: testcontainers/ryuk:0.3.3 (118s remaining)
2022-05-17 21:59:52 ERROR c.g.d.a.a.ResultCallbackTemplate(onError):52 - Error during callback
com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"Head \"https://registry-1.docker.io/v2/testcontainers/ryuk/manifests/0.3.3\": toomanyrequests: too many failed login attempts for username or IP address"}
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247) ~[testcontainers-1.17.1.jar:?]
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269) ~[testcontainers-1.17.1.jar:?]
at java.lang.Thread.run(Thread.java:833) [?:?]
2022-05-17 21:59:52 WARN o.t.i.RemoteDockerImage(resolve):104 - Retrying pull for image: testcontainers/ryuk:0.3.3 (117s remaining)
2022-05-17 21:59:52 ERROR c.g.d.a.a.ResultCallbackTemplate(onError):52 - Error during callback
com.github.dockerjava.api.exception.InternalServerErrorException: Status 500: {"message":"Head \"https://registry-1.docker.io/v2/testcontainers/ryuk/manifests/0.3.3\": toomanyrequests: too many failed login attempts for username or IP address"}
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247) ~[testcontainers-1.17.1.jar:?]
at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269) ~[testcontainers-1.17.1.jar:?]
at java.lang.Thread.run(Thread.java:833) [?:?]
2022-05-17 21:59:52 WARN o.t.i.RemoteDockerImage(resolve):104 - Retrying pull for image: testcontainers/ryuk:0.3.3 (117s remaining)as to the code itself, I expect it to compile correctly but I cannot verify that running the jooq command because of docker |
|
@supertopher I think that might just be your local. This is what I get when I try to run this: |
davinchia
approved these changes
May 18, 2022
supertopher
dismissed
malikdiarra’s stale review
outdated by newer commits and work with Davin
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Adds a new string cloumn to configs for cron closes #11418 i'm new to this task in Java please be brutal * Adds airbyte header * WIP * Rebase a week of commits * WIP for davin * deps update * Reorganize code for better readability. Also add a schema. * Update tests. * Correct bad test. * Adds note for testing version change * formatting change Co-authored-by: Davin Chia <davinchia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new string cloumn to configs for cron
closes #11418
feedback very welcome nits included
What
Adds the column using generators
Unsure if we expect testing for these. Peter's PR certainly has tests but I thought I would ask the room here