Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow following symlinks when building docker images #1332

Merged
merged 1 commit into from Dec 15, 2020

Conversation

sherifnada
Copy link
Contributor

What

This PR enables including symlinks in Docker's build context when building a connector image. This is helpful in cases where we want to use symlinks to depend on local versions of other packages in the repo.

In the consuming build.gradle, we only need to add a block

airbyteDocker {
  followSymlinks = true
}

to use this change. All current consumers should be unaffected since by default symlinks are not followed.

This is supporting work for @gordalina 's Elixir GA source

Reading order

  1. build_image.sh
  2. airbyte-docker.gradle

@sherifnada sherifnada merged commit 894c4d5 into master Dec 15, 2020
@sherifnada sherifnada deleted the sherif/follow-symlinks branch December 15, 2020 19:53
davydov-d added a commit that referenced this pull request Jan 30, 2023
davydov-d added a commit that referenced this pull request Jan 30, 2023
davydov-d added a commit that referenced this pull request Jan 30, 2023
davydov-d added a commit that referenced this pull request Feb 6, 2023
* Source Amazon Ads: fix reports stream records primary keys

* Source Amazon Ads: update changelog

* #1332 source Amazon Ads: review fixes

* #1332 source amazon ads: remove unused imports

* #1332 source amazon ads: bump major version

* auto-bump connector version

---------

Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants