Add standard tests to source google analytics #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Incremental CSV destination
Co-authored-by: jrhizor <me@jaredrhizor.com>
sherifnada
changed the title
|
@gordalina the relevant changes for you to look at will probably all be in the |
2 tasks
gordalina
reviewed
Dec 15, 2020
| } | ||
|
|
||
| airbyteStandardFsSourceTest { | ||
| configPath = "secrets/config.json" |
There was a problem hiding this comment.
Could this file be in the priv folder?
There was a problem hiding this comment.
we gitignore any secrets folder by default. If this is fine with elixir file structure, It's probably simpler to keep it in secrets. Otherwise we can definitely move to priv and gitignore that intentionally. WDYT?
There was a problem hiding this comment.
It's fine in the base path then!
|
With regards to the Dockerfile, you can remove the symlink and just have it on the |
|
@gordalina Dockerfile should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add standard source tests to airbytehq#1302. Will follow up with documentation explaining standard tests shortly.
Note, this PR contains the changes from airbytehq#1333 and airbytehq#1332. Once those are merged to master the diff should get slimmer.