Fix confirmation modal appearing when adding a transformation while creating or saving a connection #13426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
force-pushed
the
edmundito/fix-create-edit-transformation
branch
from
7981f47
to
493f29e
Compare
… a transformation * Add properties to track start/end editing in TransformationField * Bubble up prop tracking to ConnectionForm * Update CreateControls submit button to disable when form is not valid or a transformation is editing
…n transformation page * Update FormCard to be able to disable submit button and disable if form is not valid * Update TransformationView to track if transformation is edited to enable and disable submit button
edmundito
force-pushed
the
edmundito/fix-create-edit-transformation
branch
from
493f29e
to
ba38b0a
Compare
teallarson
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #12443 - An issue where the confirmation modal would appear while adding a new transformation while creating a connection.
The confirmation modal now only appears when editing the transformation but not when saving. Additionally, it ensures that the "Save connection" button is disabled while creating or editing a transformation:
How
When adding or editing a transformation, it generates a form within the main connection form. Previously, it was tracking the context of the parent form. Now it's using its own context so that the dirtiness of the form is tracked separately.
Tests
Manually tested: