Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads: add missing dependency #13618

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 8, 2022

What

https://github.com/airbytehq/oncall/issues/263
Internal server error is not represented verbose due to missing dependency which raises another exception

How

Add dependency to setup.py

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 8, 2022
@davydov-d davydov-d self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@35e65f4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 540d837 differs from pull request most recent head 2476765. Consider uploading reports for the commit 2476765 to get more accurate results

@@            Coverage Diff            @@
##             master   #13618   +/-   ##
=========================================
  Coverage          ?   92.59%           
=========================================
  Files             ?        6           
  Lines             ?      405           
  Branches          ?        0           
=========================================
  Hits              ?      375           
  Misses            ?       30           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e65f4...2476765. Read the comment docs.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 9, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2465977632
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2465977632
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               67     10    85%
source_google_ads/streams.py                 163     26    84%
source_google_ads/source.py                   80     23    71%
source_google_ads/custom_query_stream.py      75     46    39%
--------------------------------------------------------------
TOTAL                                        405    105    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 163      8    95%
source_google_ads/source.py                   80      4    95%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               67     12    82%
--------------------------------------------------------------
TOTAL                                        405     30    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 2 skipped in 194.80s (0:03:14) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 9, 2022

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2466249277
🚀 Successfully published connectors/source-google-ads
🚀 Auto-bumped version for connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2466249277

@davydov-d davydov-d merged commit 60f5f4c into master Jun 9, 2022
@davydov-d davydov-d deleted the ddavydov/#263-oncall-source-google-ads branch June 9, 2022 06:12
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets June 9, 2022 06:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants