🎉 Source Snapchat Marketing - stats streams, to beta #14577

midavadim · 2022-07-11T13:33:53Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…s/entities type

CLAassistant · 2022-07-11T13:33:59Z

All committers have signed the CLA.

midavadim · 2022-07-11T13:39:10Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/2649946991
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/2649946991
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       278     26    91%
-----------------------------------------------------------
TOTAL                                     280     26    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 32 passed, 1 skipped in 432.69s (0:07:12) ===================

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/spec.json

...nectors/source-snapchat-marketing/integration_tests/test_schemas/adaccounts_stats_daily.json

airbyte-integrations/connectors/source-snapchat-marketing/integration_tests/catalog_daily.json

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py

girarda

just a bit of nitpicking. looks good!

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/spec.json

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py

midavadim · 2022-07-15T22:08:12Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/2679610261
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/2679610261
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       273     24    91%
-----------------------------------------------------------
TOTAL                                     275     24    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 32 passed, 1 skipped in 412.01s (0:06:52) ===================

midavadim · 2022-07-15T22:25:11Z

/publish connector=connectors/source-snapchat-marketing

🕑 Publishing the following connectors:
connectors/source-snapchat-marketing
https://github.com/airbytehq/airbyte/actions/runs/2679671318

Connector	Did it publish?	Were definitions generated?
connectors/source-snapchat-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

midavadim added 9 commits July 1, 2022 21:41

implemented all stats streams, added metrics

b9bc3f9

reverted back original stream state handling

a802531

updated parse_response to handle responses from different granlaritie…

ce4ec6f

…s/entities type

added incremental sync support for stats streams

4619c64

changed depends_on_stream to parent as more common name

d306c79

code clean-up, added lifetime integration tests

8a79189

removed slice_key_name, use 'id' instead of it

fcbba2d

added integration test for daily streams

8156987

added unit tests

2997ddb

octavia-squidington-iii added the connectors/source/snapchat-marketing label Jul 11, 2022

github-actions bot added the area/connectors Connector related issues label Jul 11, 2022

midavadim requested a review from davydov-d July 11, 2022 13:40

midavadim changed the title ~~🎉 Snapchat Marketing Source - stats streams~~ 🎉 Source Snapchat Marketing - stats streams, to beta Jul 11, 2022

davydov-d requested changes Jul 12, 2022

View reviewed changes

This was linked to issues Jul 13, 2022

Source Snapchat Marketing: Add account, campaign and ads stats #10040

Closed

[EPIC] Source Snapchat to Beta #13458

Closed

midavadim added 2 commits July 13, 2022 20:19

updated spec, updated docs string for get_parent_ids

a911ba2

added unit test for cache usage in get_parent_ids

b28aac0

midavadim requested a review from davydov-d July 13, 2022 17:45

davydov-d approved these changes Jul 13, 2022

View reviewed changes

midavadim added 2 commits July 13, 2022 23:37

tune unittest

73c27c2

updated docs

8802347

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 13, 2022

midavadim requested a review from pedroslopez July 13, 2022 22:33

midavadim mentioned this pull request Jul 15, 2022

[EPIC] Source Snapchat to Beta #13458

Closed

1 task

midavadim requested a review from girarda July 15, 2022 13:09

girarda reviewed Jul 15, 2022

View reviewed changes

re-factored get_updated_state

e72c5ab

midavadim requested a review from girarda July 15, 2022 19:18

girarda approved these changes Jul 15, 2022

View reviewed changes

updated connector version

7645576

midavadim temporarily deployed to more-secrets July 15, 2022 22:07 Inactive

auto-bump connector version

6d2a415

octavia-squidington-iii temporarily deployed to more-secrets July 15, 2022 22:48 Inactive

midavadim merged commit 6b2b53e into master Jul 15, 2022

midavadim deleted the midavadim/13458-snapchat-to-beta-stats-streams branch July 15, 2022 22:50

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

lazebnyi linked an issue Jul 25, 2022 that may be closed by this pull request

Source Snapchart Marketing: Add "ad_stats" data stream #13893

Closed

lazebnyi mentioned this pull request Jul 25, 2022

Source Snapchart Marketing: Add "ad_stats" data stream #13893

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Snapchat Marketing - stats streams, to beta #14577

🎉 Source Snapchat Marketing - stats streams, to beta #14577

midavadim commented Jul 11, 2022

CLAassistant commented Jul 11, 2022 •

edited

Loading

midavadim commented Jul 11, 2022 •

edited by github-actions bot

Loading

girarda left a comment

midavadim commented Jul 15, 2022 •

edited by github-actions bot

Loading

midavadim commented Jul 15, 2022 •

edited by github-actions bot

Loading

🎉 Source Snapchat Marketing - stats streams, to beta #14577

🎉 Source Snapchat Marketing - stats streams, to beta #14577

Conversation

midavadim commented Jul 11, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Jul 11, 2022 • edited Loading

midavadim commented Jul 11, 2022 • edited by github-actions bot Loading

Build Passed

girarda left a comment

Choose a reason for hiding this comment

midavadim commented Jul 15, 2022 • edited by github-actions bot Loading

Build Passed

midavadim commented Jul 15, 2022 • edited by github-actions bot Loading

CLAassistant commented Jul 11, 2022 •

edited

Loading

midavadim commented Jul 11, 2022 •

edited by github-actions bot

Loading

midavadim commented Jul 15, 2022 •

edited by github-actions bot

Loading

midavadim commented Jul 15, 2022 •

edited by github-actions bot

Loading