Greg/guykoh update dbt clickhouse #14897
Merged
+191
−479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/documentation
|
/test connector=connectors/destination-clickhouse
Build PassedTest summary info: |
|
/test connector=connectors/destination-snowflake
Build PassedTest summary info: |
|
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
from
7289356
to
dbb93a6
Compare
github-actions
bot
added
area/documentation
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
guykoh
reviewed
Jul 21, 2022
| @@ -293,6 +293,7 @@ def transform_clickhouse(config: Dict[str, Any]): | |||
| # https://docs.getdbt.com/reference/warehouse-profiles/clickhouse-profile | |||
| dbt_config = { | |||
| "type": "clickhouse", | |||
| "driver": "clickhouse-connect", | |||
There was a problem hiding this comment.
This is not a valid value for 'driver' field - use 'native'. In fact, you don't need that field at all, the connector will derive the driver protocol from the port (9440).
There was a problem hiding this comment.
hrm. will try setting it explicitly - integration tests were failing because driver was being set to None:
1 check failed:
dbt was unable to connect to the specified database.
The database returned the following error:
>Database Error
Library for ClickHouse driver type None not found
There was a problem hiding this comment.
Ran the tests locally and ran into this error:
14:29:05 Compilation Error in model dedup_exchange_rate_ab1 (models/generated/airbyte_ctes/test_normalization/dedup_exchange_rate_ab1.sql)
14:29:05 No materialization 'ignore' was found for adapter clickhouse! (searched types 'default' and 'clickhouse')
Maybe the approach here is be to use either view materialization, or materialize as tables and then drop the tables afterward, unless I'm misunderstanding the intent?
There was a problem hiding this comment.
Sure, let's use view materialization instead.
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
from
372f97b
to
3eb3b7a
Compare
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
|
/test connector=bases/base-normalization
Build FailedTest summary info: |
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
2 times, most recently
from
ccb430c
to
9d818b0
Compare
|
/test connector=bases/base-normalization
Build FailedTest summary info:
Build FailedTest summary info: |
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
from
b3cdbf9
to
e4964b9
Compare
|
/test connector=bases/base-normalization
Build PassedTest summary info: |
|
/test connector=connectors/destination-clickhouse
Build PassedTest summary info: |
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
from
e4964b9
to
6fe668d
Compare
grishick
force-pushed
the
greg/guykoh_update_dbt_clickhouse
branch
from
6fe668d
to
bd2dd4a
Compare
|
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
This was referenced Aug 23, 2022
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
* Update dbt-clickhouse version to 1.1.7 to support AirByte on ClickHouse cloud * Fix quote handling in Clickhouse normalization tests * Update test output for Clickhouse * Bump version and update changelog Co-authored-by: guykohen <guy@clickhouse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update dbt-clickhouse version to support Airbyte on ClickHouse cloud
This is an internal PR to run CI for this contributor PR