🎉 Source Facebook Marketing: Added custom conversions stream #15724

mlavoie-sm360 · 2022-08-17T15:38:49Z

What

Solves issue #15723 by adding a custom conversions stream

How

Added required schema and stream.

User Impact

No breaking changes. Adds support for new stream.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

marcosmarxm · 2022-08-17T16:26:25Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2876861043
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2876861043
🐛 https://gradle.com/s/zhr7l3vfqbwo4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so...
================== 1 failed, 28 passed in 1686.47s (0:28:06) ===================

sajarin · 2022-08-18T17:16:43Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2884120547
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2884120547
🐛 https://gradle.com/s/fpzc4t5ajttvq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so...
================== 1 failed, 28 passed in 1767.96s (0:29:27) ===================

mlavoie-sm360 · 2022-08-29T06:08:05Z

What is the process for changes to be merged? Should I be doing something else at this point in the process?

marcosmarxm · 2022-08-29T21:46:51Z

/test connector=connectors/source-facebook-marketing

marcosmarxm · 2022-08-29T21:48:00Z

What is the process for changes to be merged? Should I be doing something else at this point in the process?

I rebased your branch with master to solve the test issue. Let's see the latest /test run

marcosmarxm · 2022-08-29T21:59:53Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2952048816
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2952048816
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             128     27    79%
source_facebook_marketing/streams/common.py                    40     13    68%
source_facebook_marketing/source.py                            42     16    62%
source_facebook_marketing/streams/streams.py                  117     45    62%
source_facebook_marketing/utils.py                             25     10    60%
source_facebook_marketing/streams/base_insight_streams.py     132     54    59%
source_facebook_marketing/streams/async_job.py                214    134    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         913    371    59%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             25      0   100%
source_facebook_marketing/streams/common.py                    40      0   100%
source_facebook_marketing/streams/async_job.py                214      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              37      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/source.py                            42      1    98%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     132     13    90%
source_facebook_marketing/streams/streams.py                  117     27    77%
source_facebook_marketing/streams/base_streams.py             128     30    77%
-------------------------------------------------------------------------------
TOTAL                                                         913     83    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

marcosmarxm · 2022-08-30T16:11:18Z

@lazebnyi can you do the final review for this community contribution?

marcosmarxm · 2022-09-01T19:24:44Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2974373675

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-09-01T21:44:33Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2975145386

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-09-06T20:21:28Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/3003138421

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…hq#15724) * 🎉 Source Facebook Marketing: Added support for custom conversions stream * solve md conflict and update dockerfile version * Updated test_streams test * auto-bump connector version [ci skip] Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

github-actions bot added the area/connectors Connector related issues label Aug 17, 2022

octavia-squidington-iii added bounty community connectors/source/facebook-marketing labels Aug 17, 2022

mlavoie-sm360 changed the title ~~Source facebook marketing added customconversions stream~~ 🎉 Source Facebook Marketing: Added custom conversions stream Aug 17, 2022

github-actions bot added the area/documentation Improvements or additions to documentation label Aug 17, 2022

sajarin added internal and removed bounty labels Aug 18, 2022

marcosmarxm force-pushed the source-facebook-marketing-added-customconversions-stream branch from 052ece2 to c893c8c Compare August 29, 2022 21:46

marcosmarxm requested a review from lazebnyi August 30, 2022 16:10

marcosmarxm self-assigned this Aug 30, 2022

lazebnyi approved these changes Sep 1, 2022

View reviewed changes

marcosmarxm force-pushed the source-facebook-marketing-added-customconversions-stream branch from b8c0734 to 1673370 Compare September 1, 2022 21:44

mlavoie-sm360 and others added 3 commits September 6, 2022 17:19

🎉 Source Facebook Marketing: Added support for custom conversions stream

0b43b3f

solve md conflict and update dockerfile version

9bcc8e3

Updated test_streams test

2231005

marcosmarxm force-pushed the source-facebook-marketing-added-customconversions-stream branch from 1673370 to 2231005 Compare September 6, 2022 20:21

auto-bump connector version [ci skip]

3bbbdf9

marcosmarxm approved these changes Sep 6, 2022

View reviewed changes

marcosmarxm merged commit 8cd3880 into airbytehq:master Sep 6, 2022

mlavoie-sm360 deleted the source-facebook-marketing-added-customconversions-stream branch September 7, 2022 05:46

octavia-squidington-iii mentioned this pull request Sep 12, 2022

Bump Airbyte version from 0.40.4 to 0.40.5 #16610

Merged

artem1205 mentioned this pull request May 26, 2023

Source Facebook Marketing: new stream Custom Conversions #17237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Facebook Marketing: Added custom conversions stream #15724

🎉 Source Facebook Marketing: Added custom conversions stream #15724

mlavoie-sm360 commented Aug 17, 2022 •

edited

Loading

marcosmarxm commented Aug 17, 2022 •

edited by github-actions bot

Loading

sajarin commented Aug 18, 2022 •

edited by github-actions bot

Loading

mlavoie-sm360 commented Aug 29, 2022 •

edited

Loading

marcosmarxm commented Aug 29, 2022

marcosmarxm commented Aug 29, 2022

marcosmarxm commented Aug 29, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Aug 30, 2022

marcosmarxm commented Sep 1, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 1, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 6, 2022 •

edited by github-actions bot

Loading

🎉 Source Facebook Marketing: Added custom conversions stream #15724

🎉 Source Facebook Marketing: Added custom conversions stream #15724

Conversation

mlavoie-sm360 commented Aug 17, 2022 • edited Loading

What

How

User Impact

Pre-merge Checklist

Community member or Airbyter

Airbyter

marcosmarxm commented Aug 17, 2022 • edited by github-actions bot Loading

Build Failed

sajarin commented Aug 18, 2022 • edited by github-actions bot Loading

Build Failed

mlavoie-sm360 commented Aug 29, 2022 • edited Loading

marcosmarxm commented Aug 29, 2022

marcosmarxm commented Aug 29, 2022

marcosmarxm commented Aug 29, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Aug 30, 2022

marcosmarxm commented Sep 1, 2022 • edited by github-actions bot Loading

marcosmarxm commented Sep 1, 2022 • edited by github-actions bot Loading

marcosmarxm commented Sep 6, 2022 • edited by github-actions bot Loading

mlavoie-sm360 commented Aug 17, 2022 •

edited

Loading

marcosmarxm commented Aug 17, 2022 •

edited by github-actions bot

Loading

sajarin commented Aug 18, 2022 •

edited by github-actions bot

Loading

mlavoie-sm360 commented Aug 29, 2022 •

edited

Loading

marcosmarxm commented Aug 29, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 1, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 1, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 6, 2022 •

edited by github-actions bot

Loading