Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing tool commands for run scenarios #17550

Merged
merged 5 commits into from Oct 7, 2022

Conversation

andriikorotkov
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 4, 2022 08:57 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 4, 2022

/help-full name="Update destination version scenario"

Error: Unexpected inputs provided: ["name"]

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 4, 2022

/help-full name="Update destination version scenario"

https://github.com/airbytehq/airbyte/actions/runs/3181418727

Scenario Update destination version scenario. ✔️

ℹ️ Configure default connection, set destination version. After sync, update version and repeat sync

Call examples :

  • Run scenario : /run-scenario name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
  • Run scenario with local creds : /run-scenario-local name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
    Note! The local scenario run requires file names in the folder secrets\. For example, some_cred_1=local_file.json
  • Get short help : /help name="Update destination version scenario"

Instances in the scenario

  • name : airbyte_1
    type : AIRBYTE
    credentials : airbyte_creds

  • name : source_1
    type : SOURCE
    credentials : source_creds

  • name : destination_1
    type : DESTINATION
    credentials : destination_creds

  • name : connection_1
    type : CONNECTION

Parameters in the scenario

  • name : new_version
    type : destination_version

  • name : old_version
    type : destination_version

Scenario actions

Preparation actions :
  • action : CONNECT_AIRBYTE_API
    resultInstance : airbyte_1

  • action : CREATE_SOURCE
    requiredInstances : [airbyte_1]
    resultInstance : source_1

  • action : CREATE_DESTINATION
    requiredInstances : [airbyte_1]
    resultInstance : destination_1

  • action : READ_DESTINATION_VERSION
    requiredInstances : [destination_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [old_version]

  • action : CREATE_CONNECTION
    requiredInstances : [source_1, destination_1]
    resultInstance : connection_1

Scenario actions :
  • action : SYNC_CONNECTION
    requiredInstances : [connection_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [new_version]

  • action : SYNC_CONNECTION
    requiredInstances : [connection_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [before_test_version]

@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 4, 2022 10:38 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 7, 2022 10:03 Inactive
@andriikorotkov andriikorotkov changed the title Test testing tool commands Testing tool commands for run scenarios Oct 7, 2022
@andriikorotkov andriikorotkov marked this pull request as ready for review October 7, 2022 10:05
@andriikorotkov andriikorotkov merged commit 0bec940 into master Oct 7, 2022
@andriikorotkov andriikorotkov deleted the akorotkov/test_testing_tool_command branch October 7, 2022 11:07
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 7, 2022

/help-full name="Update destination version scenario"

https://github.com/airbytehq/airbyte/actions/runs/3204294961

Scenario Update destination version scenario. ✔️

ℹ️ Configure default connection, set destination version. After sync, update version and repeat sync

Call examples :

  • Run scenario : /run-scenario name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
  • Run scenario with local creds : /run-scenario-local name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
    Note! The local scenario run requires file names in the folder secrets\. For example, some_cred_1=local_file.json
  • Get short help : /help name="Update destination version scenario"

Instances in the scenario

  • name : airbyte_1
    type : AIRBYTE
    credentials : airbyte_creds

  • name : source_1
    type : SOURCE
    credentials : source_creds

  • name : destination_1
    type : DESTINATION
    credentials : destination_creds

  • name : connection_1
    type : CONNECTION

Parameters in the scenario

  • name : new_version
    type : destination_version

  • name : old_version
    type : destination_version

Scenario actions

Preparation actions :
  • action : CONNECT_AIRBYTE_API
    resultInstance : airbyte_1

  • action : CREATE_SOURCE
    requiredInstances : [airbyte_1]
    resultInstance : source_1

  • action : CREATE_DESTINATION
    requiredInstances : [airbyte_1]
    resultInstance : destination_1

  • action : READ_DESTINATION_VERSION
    requiredInstances : [destination_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [old_version]

  • action : CREATE_CONNECTION
    requiredInstances : [source_1, destination_1]
    resultInstance : connection_1

Scenario actions :
  • action : SYNC_CONNECTION
    requiredInstances : [connection_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [new_version]

  • action : SYNC_CONNECTION
    requiredInstances : [connection_1]

  • action : UPDATE_DESTINATION_VERSION
    requiredInstances : [destination_1]
    requiredParameters : [before_test_version]

letiescanciano added a commit that referenced this pull request Oct 7, 2022
…vation

* master: (32 commits)
  fixed octavia position and z-index on onboarding page (#17708)
  Revert "Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)" (#17669)
  source-google-analytics-v4: use hits metric for check (#17717)
  Source linkedin-ads: retry 429/5xx when refreshing access token (#17724)
  🐛 Source Mixpanel: solve cursor field none expected array (#17699)
  🎉 8890 Source MySql: Fix large table issue by fetch size (#17236)
  Test e2e testing tool commands (#17722)
  fixed escape character i18n error (#17706)
  Docs: adds missing " in transformations-with-airbyte.md (#17723)
  Change Osano token to new project (#17720)
  Source Github: improve 502 handling for `comments` stream (#17715)
  #17506 source snapchat marketing: retry failed request for refreshing access token (#17596)
  MongoDb Source: Increase performance of discover (#17614)
  Testing tool commands for run scenarios (#17550)
  Kustomize: Missing NORMALIZATION_JOB_* environment variables in stable-with-resource-limits overlays (#17713)
  Fix console errors (#17696)
  Revert: #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17707)
  #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17626)
  📝 Postgres source: document occasional full refresh under cdc mode (#17705)
  Bump Airbyte version from 0.40.12 to 0.40.13 (#17682)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* test pull request for testing testing-tool commands

* test pull request for testing testing-tool commands

* add command for run testing tool in main repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants