Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-google-analytics-v4: use hits metric for check #17717

Merged
merged 3 commits into from Oct 7, 2022
Merged

source-google-analytics-v4: use hits metric for check #17717

merged 3 commits into from Oct 7, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 7, 2022 •
edited

What

To check connection the Google Analytics connectors queries a simple report with the ga:14dayUsers metric.
This metric is not appropriate because account with low traffic does not have data for this metrics, which cause the CHECK to fail.
OC issue

How

Use ga:hits metric

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 7, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 7, 2022
@alafanechere alafanechere marked this pull request as ready for review October 7, 2022 08:26
@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 7, 2022 •
edited by github-actions bot

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/3204455588
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/3204455588
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       284     26    91%
------------------------------------------------------------
TOTAL                                      286     26    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 7, 2022 •
edited by github-actions bot

/publish connector=connectors/source-google-analytics-v4 run-tests=false

🕑 Publishing the following connectors:
connectors/source-google-analytics-v4
https://github.com/airbytehq/airbyte/actions/runs/3205457825


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-v4 ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere merged commit e57693f into master Oct 7, 2022
@alafanechere alafanechere deleted the augustin/source-google-analytics-v4/improve-check branch October 7, 2022 14:38
letiescanciano added a commit that referenced this pull request Oct 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-speedy-connection-for-acti…
e7b49b2 
…vation

* master: (32 commits)
  fixed octavia position and z-index on onboarding page (#17708)
  Revert "Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)" (#17669)
  source-google-analytics-v4: use hits metric for check (#17717)
  Source linkedin-ads: retry 429/5xx when refreshing access token (#17724)
  🐛 Source Mixpanel: solve cursor field none expected array (#17699)
  🎉 8890 Source MySql: Fix large table issue by fetch size (#17236)
  Test e2e testing tool commands (#17722)
  fixed escape character i18n error (#17706)
  Docs: adds missing " in transformations-with-airbyte.md (#17723)
  Change Osano token to new project (#17720)
  Source Github: improve 502 handling for `comments` stream (#17715)
  #17506 source snapchat marketing: retry failed request for refreshing access token (#17596)
  MongoDb Source: Increase performance of discover (#17614)
  Testing tool commands for run scenarios (#17550)
  Kustomize: Missing NORMALIZATION_JOB_* environment variables in stable-with-resource-limits overlays (#17713)
  Fix console errors (#17696)
  Revert: #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17707)
  #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17626)
  📝 Postgres source: document occasional full refresh under cdc mode (#17705)
  Bump Airbyte version from 0.40.12 to 0.40.13 (#17682)
  ...
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 7, 2022
Merged
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@alafanechere @jhammarstedt
source-google-analytics-v4: use hits metric for check (airbytehq#17717)
090ec5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

@grubberr grubberr Awaiting requested review from grubberr

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4 from/connector-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alafanechere @pedroslopez @octavia-squidington-iv @octavia-squidington-iii