Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟🧪 [Experiment] add hideOnboarding experiment #17605

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Oct 5, 2022

What

Closes #17416, enabling an experiment to hide onboarding.

How

  • Adds a onboarding.hideOnboarding feature flag to LaunchDarkly
  • This boolean flag toggles whether the onboarding route is accessible for cloud users.
  • When disabled, users are redirected to /connections after login.

Note: As far as I understand, feature flags are not used on OSS, so src/pages/routes.tsx remains unchanged (onboarding remains visible).

Before (or with feature flag disabled):
image

After (with feature flag enabled):
image

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 5, 2022
@timroes timroes marked this pull request as ready for review October 5, 2022 16:36
@timroes timroes requested a review from a team as a code owner October 5, 2022 16:36
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally and it works. This is only implemented for the cloud routes at the moment (and not for OSS), which is okay, since we anyway don't use LaunchDarkly in OSS, thus it would never have an effect there.

@josephkmh josephkmh merged commit f00680c into master Oct 5, 2022
@josephkmh josephkmh deleted the joey/hide-onboarding-experiment branch October 5, 2022 17:50
letiescanciano added a commit that referenced this pull request Oct 6, 2022
…vation

* master: (26 commits)
  supply a source id for schema discovery in connector integration tests (#17662)
  Source Iterable: Add permission check for stream (#17602)
  Moving TrackingClientSingleton.initialize into the bean itself (#17631)
  Handle null workspace IDs in tracking/reporting methods gracefully (#17641)
  Bump Airbyte version from 0.40.11 to 0.40.12 (#17653)
  Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)
  Standardize HttpRequester's url_base and path format (#17524)
  Create geography_type enum and add geography column in connection and workspace table (#16818)
  airbyte-cron: update connector definitions from remote (#16438)
  Do not wait the end of a reset to return an update (#17591)
  Remove redundant title labels from connector specs (#17544)
  Updated GA4 status
  support large schema discovery (#17394)
  🪟 🐛 Fixes connector checks not properly ending their loading state (#17620)
  🪟🧪 [Experiment] add hideOnboarding experiment (#17605)
  Source Recharge: change releaseStage to GA (#17606)
  Source Recharge: skip stream if 403 received (#17608)
  remove sonar-scan workflow (#17609)
  Mark/tables should be full width on all pages (#17401)
  Auto fail all workfow if there is a Versioning issue (#17562)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add experiment to hide to onboarding page
3 participants