Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark/tables should be full width on all pages #17401

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

matter-q
Copy link
Contributor

@matter-q matter-q commented Sep 29, 2022

What

Closes #16512

How

Added margin/padding 20px as standard for all pages.

Loom

https://www.loom.com/share/1f6b819ba5954c2fbd9d47ced66dca40

@matter-q matter-q changed the title Mark/tables should be full width on all pages 2 Mark/tables should be full width on all pages Sep 29, 2022
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 29, 2022
@matter-q matter-q force-pushed the mark/tables-should-be-full-width-on-all-pages-2 branch 3 times, most recently from bafc705 to e835e7a Compare September 30, 2022 12:10
@matter-q matter-q marked this pull request as ready for review September 30, 2022 12:36
@matter-q matter-q requested a review from a team as a code owner September 30, 2022 12:36
@matter-q matter-q force-pushed the mark/tables-should-be-full-width-on-all-pages-2 branch 3 times, most recently from 82d64b1 to f0d482d Compare September 30, 2022 18:34
Added margins/padding left and right as standard 20px
@matter-q matter-q force-pushed the mark/tables-should-be-full-width-on-all-pages-2 branch from f0d482d to e78ab92 Compare September 30, 2022 21:38
Added margins/padding left and right as standard 20px
Added margins/padding left and right as standard 20px
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@matter-q matter-q merged commit 2742e0b into master Oct 5, 2022
@matter-q matter-q deleted the mark/tables-should-be-full-width-on-all-pages-2 branch October 5, 2022 15:58
letiescanciano added a commit that referenced this pull request Oct 6, 2022
…vation

* master: (26 commits)
  supply a source id for schema discovery in connector integration tests (#17662)
  Source Iterable: Add permission check for stream (#17602)
  Moving TrackingClientSingleton.initialize into the bean itself (#17631)
  Handle null workspace IDs in tracking/reporting methods gracefully (#17641)
  Bump Airbyte version from 0.40.11 to 0.40.12 (#17653)
  Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)
  Standardize HttpRequester's url_base and path format (#17524)
  Create geography_type enum and add geography column in connection and workspace table (#16818)
  airbyte-cron: update connector definitions from remote (#16438)
  Do not wait the end of a reset to return an update (#17591)
  Remove redundant title labels from connector specs (#17544)
  Updated GA4 status
  support large schema discovery (#17394)
  🪟 🐛 Fixes connector checks not properly ending their loading state (#17620)
  🪟🧪 [Experiment] add hideOnboarding experiment (#17605)
  Source Recharge: change releaseStage to GA (#17606)
  Source Recharge: skip stream if 403 received (#17608)
  remove sonar-scan workflow (#17609)
  Mark/tables should be full width on all pages (#17401)
  Auto fail all workfow if there is a Versioning issue (#17562)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Removed styled-components
Added margins/padding left and right as standard 20px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Tables should be full width on all pages
2 participants