Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: remove "format" from optional datetime "end_date" field #17869

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Source Facebook Marketing: remove "format" from optional datetime "end_date" field #17869

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6666ffa
bump 0.2.68
grubberr Oct 12, 2022
917a8aa
remove format from end_date
grubberr Oct 12, 2022
cecb706
facebook-marketing.md updated
grubberr Oct 12, 2022
4727c05
auto-bump connector version [ci skip]
octavia-squidington-iii Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]


LABEL io.airbyte.version=0.2.67
LABEL io.airbyte.version=0.2.68
LABEL io.airbyte.name=airbyte/source-facebook-marketing
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ connector_image: airbyte/source-facebook-marketing:dev
tests:
spec:
- spec_path: "integration_tests/spec.json"
backward_compatibility_tests_config:
disable_for_version: "0.2.60"
connection:
- config_path: "secrets/config.json"
status: "succeed"
Expand Down
3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-facebook-marketing/integration_tests/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
"order": 2,
"pattern": "^$|^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$",
"examples": ["2017-01-26T00:00:00Z"],
"type": "string",
"format": "date-time"
"type": "string"
},
"access_token": {
"title": "Access Token",
Expand Down
6 changes: 5 additions & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import logging
from datetime import datetime, timezone
from enum import Enum
from typing import List, Optional
from typing import Any, Dict, List, Optional, Type

from airbyte_cdk.sources.config import BaseConfig
from facebook_business.adobjects.adsinsights import AdsInsights
Expand Down Expand Up @@ -92,6 +92,10 @@ class ConnectorConfig(BaseConfig):
class Config:
title = "Source Facebook Marketing"

@staticmethod
def schema_extra(schema: Dict[str, Any], model: Type["ConnectorConfig"]) -> None:
schema["properties"]["end_date"].pop("format")

account_id: str = Field(
title="Account ID",
order=0,
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/facebook-marketing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ Please be informed that the connector uses the `lookback_window` parameter to pe

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| 0.2.68 | 2022-10-12 | [17869](https://github.com/airbytehq/airbyte/pull/17869) | Remove "format" from optional datetime `end_date` field |
| 0.2.67 | 2022-10-04 | [17551](https://github.com/airbytehq/airbyte/pull/17551) | Add `cursor_field` for custom_insights stream schema |
| 0.2.65 | 2022-09-29 | [17371](https://github.com/airbytehq/airbyte/pull/17371) | Fix stream CustomConversions `enable_deleted=False` |
| 0.2.64 | 2022-09-22 | [17304](https://github.com/airbytehq/airbyte/pull/17304) | Migrate to per-stream state. |
Expand Down