-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: CoinGecko Coins [low-code cdk] #18248
🎉 New Source: CoinGecko Coins [low-code cdk] #18248
Conversation
Thanks for the PR @isaacharrisholt, this PR is part of AIrbyte's Community Maintainer program and someone from our community will be assigned to help get this PR merged into our main branch. Please ping me if you don't hear anything back within 48 hours! Happy Hacktober! :) |
assigned to @jacqueskpoty |
@isaacharrisholt Great work. Thanks for your contribution. Could you add the connector's documentation to the docs/integrations/sources folder? It should be named coinGecko.md |
Done! I named it |
@isaacharrisholt It 'is not an issue. I took a look at it and it looks good. We will take it from here. We will get back to you if needs be. Thanks again for your contributions. |
@isaacharrisholt Could you follow the step-11 in this document (https://docs.airbyte.com/connector-development/tutorials/building-a-python-source) so as to add a sourcceDefinitionId to the your connector. Let me know if you need any help with it. Thanks |
@jacqueskpoty All done! |
dockerRepository: airbyte/source-coingecko-coins | ||
dockerImageTag: 0.1.0 | ||
documentationUrl: https://docs.airbyte.com/integrations/sources/coingecko-coins | ||
icon: coingeckocoins.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaacharrisholt Please add this icon to the following folder :
airbyte-config/init/src/main/resources/icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hey, is there any update on this? |
The team is working on testing now.
…On Wed, Nov 9, 2022 at 9:54 AM Isaac Harris-Holt ***@***.***> wrote:
Hey, is there any update on this?
—
Reply to this email directly, view it on GitHub
<#18248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZEBEVHIBJQEXMGGL2FI23WHO3KDANCNFSM6AAAAAARKJIMRE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Great, thank you! |
@isaacharrisholt can you share any screenshots of passing tests? (Or can you share any credentials with our team?) |
There are screenshots in the pull request description above. |
/test connector=connectors/source-coingecko-coins
Build PassedTest summary info:
|
/publish connector=connectors/source-coingecko-coins
if you have connectors that successfully published but failed definition generation, follow step 4 here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isaacharrisholt
What
It's often useful for FinTech companies to have access to market data. This connector adds data from the CoinGecko coins API to allow this.
How
This connector adds the following streams:
market_chart
history
(to be made incremental in future)Recommended reading order
coingecko_coins.yaml
spec.yaml
🚨 User Impact 🚨
No changes to existing code.
Pre-merge Checklist
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
None.
Integration
Acceptance