🎉 New Source: CoinGecko Coins [low-code cdk] #18248

isaacharrisholt · 2022-10-20T15:43:30Z

What

It's often useful for FinTech companies to have access to market data. This connector adds data from the CoinGecko coins API to allow this.

How

This connector adds the following streams:

market_chart
history (to be made incremental in future)

🚨 User Impact 🚨

No changes to existing code.

Pre-merge Checklist

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

None.

Integration

Acceptance

sajarin · 2022-10-20T17:11:33Z

Thanks for the PR @isaacharrisholt, this PR is part of AIrbyte's Community Maintainer program and someone from our community will be assigned to help get this PR merged into our main branch. Please ping me if you don't hear anything back within 48 hours!

Happy Hacktober! :)

sajarin · 2022-10-20T17:13:37Z

assigned to @jacqueskpoty

jacqueskpoty · 2022-10-24T05:14:06Z

@isaacharrisholt Great work. Thanks for your contribution. Could you add the connector's documentation to the docs/integrations/sources folder? It should be named coinGecko.md
Please follow other connectors documentation examples in the same folder to complete the documentation.

isaacharrisholt · 2022-10-24T18:38:22Z

@isaacharrisholt Great work. Thanks for your contribution. Could you add the connector's documentation to the docs/integrations/sources folder? It should be named coinGecko.md Please follow other connectors documentation examples in the same folder to complete the documentation.

Done! I named it coingecko-coins.md to follow the format of the others. Please let me know if this is an issue @jacqueskpoty

jacqueskpoty · 2022-10-26T15:42:28Z

@isaacharrisholt It 'is not an issue. I took a look at it and it looks good. We will take it from here. We will get back to you if needs be. Thanks again for your contributions.

jacqueskpoty · 2022-11-01T13:33:33Z

@isaacharrisholt Could you follow the step-11 in this document (https://docs.airbyte.com/connector-development/tutorials/building-a-python-source) so as to add a sourcceDefinitionId to the your connector. Let me know if you need any help with it. Thanks

isaacharrisholt · 2022-11-01T14:08:43Z

@isaacharrisholt Could you follow the step-11 in this document (https://docs.airbyte.com/connector-development/tutorials/building-a-python-source) so as to add a sourcceDefinitionId to the your connector. Let me know if you need any help with it. Thanks

@jacqueskpoty All done!

jacqueskpoty · 2022-11-03T18:59:15Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+  dockerRepository: airbyte/source-coingecko-coins
+  dockerImageTag: 0.1.0
+  documentationUrl: https://docs.airbyte.com/integrations/sources/coingecko-coins
+  icon: coingeckocoins.svg


@isaacharrisholt Please add this icon to the following folder :
airbyte-config/init/src/main/resources/icons

isaacharrisholt · 2022-11-09T14:54:14Z

Hey, is there any update on this?

jacqueskpoty · 2022-11-09T14:57:06Z

The team is working on testing now.

…

On Wed, Nov 9, 2022 at 9:54 AM Isaac Harris-Holt ***@***.***> wrote: Hey, is there any update on this? — Reply to this email directly, view it on GitHub <#18248 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZEBEVHIBJQEXMGGL2FI23WHO3KDANCNFSM6AAAAAARKJIMRE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

isaacharrisholt · 2022-11-09T15:24:55Z

The team is working on testing now.
…
On Wed, Nov 9, 2022 at 9:54 AM Isaac Harris-Holt @.> wrote: Hey, is there any update on this? — Reply to this email directly, view it on GitHub <#18248 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZEBEVHIBJQEXMGGL2FI23WHO3KDANCNFSM6AAAAAARKJIMRE . You are receiving this because you were mentioned.Message ID: @.>

Great, thank you!

sajarin · 2022-11-14T18:19:03Z

@isaacharrisholt can you share any screenshots of passing tests? (Or can you share any credentials with our team?)

isaacharrisholt · 2022-11-14T18:21:33Z

@isaacharrisholt can you share any screenshots of passing tests? (Or can you share any credentials with our team?)

There are screenshots in the pull request description above.

marcosmarxm · 2022-11-17T23:13:31Z

/test connector=connectors/source-coingecko-coins

🕑 connectors/source-coingecko-coins https://github.com/airbytehq/airbyte/actions/runs/3492765254
✅ connectors/source-coingecko-coins https://github.com/airbytehq/airbyte/actions/runs/3492765254
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:88: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:358: The previous connector image could not be retrieved.
================= 26 passed, 3 skipped, 29 warnings in 24.96s ==================

marcosmarxm · 2022-11-18T00:46:09Z

/publish connector=connectors/source-coingecko-coins

🕑 Publishing the following connectors:
connectors/source-coingecko-coins
https://github.com/airbytehq/airbyte/actions/runs/3493227570

Connector	Did it publish?	Were definitions generated?
connectors/source-coingecko-coins	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @isaacharrisholt

isaacharrisholt added 2 commits October 20, 2022 14:52

Initial commit

b318797

Add streams

9b5869e

github-actions bot added the area/connectors Connector related issues label Oct 20, 2022

octavia-squidington-iv added bounty community connectors/source/coingecko-coins labels Oct 20, 2022

isaacharrisholt changed the title ~~Coingecko coins~~ 🎉 New Source: CoinGecko Coins Oct 20, 2022

sajarin added the bounty-XL Maintainer program: claimable extra large bounty PR label Oct 20, 2022

marcosmarxm added the hacktober label Oct 20, 2022

RealChrisSean mentioned this pull request Oct 22, 2022

New Source: CoinGecko Coins airbytehq/connector-contest#176

Closed

sajarin assigned jacqueskpoty Oct 24, 2022

Add docs

ff05350

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 24, 2022

bleonard added the reward-200 label Oct 31, 2022

Add sourceDefinition

9ee5c74

jacqueskpoty reviewed Nov 3, 2022

View reviewed changes

Add icon

0e5f438

Merge branch 'master' into coingecko_coins

a30a1d7

auto-bump connector version

7c800de

octavia-squidington-iii requested a review from a team November 18, 2022 01:04

Merge branch 'master' into coingecko_coins

a85c6b5

marcosmarxm approved these changes Nov 18, 2022

View reviewed changes

marcosmarxm merged commit 4946ce7 into airbytehq:master Nov 18, 2022

github-actions bot mentioned this pull request Nov 18, 2022

Bump helm chart version reference to 0.41.0 #19607

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.19 to 0.40.20 #19614

Merged

marcosmarxm added the low-code label Nov 18, 2022

marcosmarxm changed the title ~~🎉 New Source: CoinGecko Coins~~ 🎉 New Source: CoinGecko Coins [low-code cdk] Nov 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: CoinGecko Coins [low-code cdk] #18248

🎉 New Source: CoinGecko Coins [low-code cdk] #18248

isaacharrisholt commented Oct 20, 2022

sajarin commented Oct 20, 2022

sajarin commented Oct 20, 2022

jacqueskpoty commented Oct 24, 2022

isaacharrisholt commented Oct 24, 2022 •

edited

Loading

jacqueskpoty commented Oct 26, 2022

jacqueskpoty commented Nov 1, 2022

isaacharrisholt commented Nov 1, 2022

jacqueskpoty Nov 3, 2022

isaacharrisholt Nov 3, 2022

isaacharrisholt commented Nov 9, 2022

jacqueskpoty commented Nov 9, 2022 via email

isaacharrisholt commented Nov 9, 2022

sajarin commented Nov 14, 2022

isaacharrisholt commented Nov 14, 2022

marcosmarxm commented Nov 17, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

🎉 New Source: CoinGecko Coins [low-code cdk] #18248

🎉 New Source: CoinGecko Coins [low-code cdk] #18248

Conversation

isaacharrisholt commented Oct 20, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

sajarin commented Oct 20, 2022

sajarin commented Oct 20, 2022

jacqueskpoty commented Oct 24, 2022

isaacharrisholt commented Oct 24, 2022 • edited Loading

jacqueskpoty commented Oct 26, 2022

jacqueskpoty commented Nov 1, 2022

isaacharrisholt commented Nov 1, 2022

jacqueskpoty Nov 3, 2022

Choose a reason for hiding this comment

isaacharrisholt Nov 3, 2022

Choose a reason for hiding this comment

isaacharrisholt commented Nov 9, 2022

jacqueskpoty commented Nov 9, 2022 via email

isaacharrisholt commented Nov 9, 2022

sajarin commented Nov 14, 2022

isaacharrisholt commented Nov 14, 2022

marcosmarxm commented Nov 17, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 18, 2022 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

isaacharrisholt commented Oct 24, 2022 •

edited

Loading

marcosmarxm commented Nov 17, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 18, 2022 •

edited by github-actions bot

Loading