Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Tempo: migrate to lowcode + certify to beta #18936

Merged
merged 6 commits into from
Nov 14, 2022

Conversation

davydov-d
Copy link
Collaborator

What

#18682

How

Migrate to low code, set up tests, edit docs etc

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 3, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 3, 2022

/test connector=connectors/source-tempo

🕑 connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3388677118
❌ connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3388677118
🐛 https://gradle.com/s/xk7rxax6u63ya

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
ERROR test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs1]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.2.6.
======== 5 failed, 23 passed, 1 skipped, 2 errors in 143.31s (0:02:23) =========

@davydov-d
Copy link
Collaborator Author

bloked by #18931

@davydov-d davydov-d temporarily deployed to more-secrets November 3, 2022 19:26 Inactive
@grubberr
Copy link
Contributor

grubberr commented Nov 4, 2022

@davydov-d is it ok?

$ python3 main.py discover --config secrets/config.json | jq .catalog.streams[].source_defined_primary_key
null
null
[
  [
    "tempoWorklogId"
  ]
]
null

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 4, 2022

/test connector=connectors/source-tempo

🕑 connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3392143201
❌ connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3392143201
🐛 https://gradle.com/s/pczyiqnpsdhfw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contai...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.2.6.
============= 1 failed, 29 passed, 1 skipped in 223.33s (0:03:43) ==============

@davydov-d
Copy link
Collaborator Author

@davydov-d is it ok?

$ python3 main.py discover --config secrets/config.json | jq .catalog.streams[].source_defined_primary_key
null
null
[
  [
    "tempoWorklogId"
  ]
]
null

fixed it, thanks!

@davydov-d davydov-d temporarily deployed to more-secrets November 4, 2022 08:21 Inactive
@davydov-d davydov-d temporarily deployed to more-secrets November 4, 2022 08:55 Inactive
@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 4, 2022

/test connector=connectors/source-tempo

🕑 connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3392773250
✅ connectors/source-tempo https://github.com/airbytehq/airbyte/actions/runs/3392773250
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:235: Backward compatibility tests are disabled for version 0.2.6.
================== 30 passed, 1 skipped in 261.65s (0:04:21) ===================

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved assuming the expected_records were created from the original implementation

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 14, 2022

/publish connector=connectors/source-tempo

🕑 Publishing the following connectors:
connectors/source-tempo
https://github.com/airbytehq/airbyte/actions/runs/3459702403


Connector Did it publish? Were definitions generated?
connectors/source-tempo

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 8ff8bec into master Nov 14, 2022
@davydov-d davydov-d deleted the ddavydov/#18682-source-tempo-to-yaml-beta branch November 14, 2022 08:53
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 14, 2022 08:55 Inactive
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* #18682 source tempo: migrate to lowcode + certify to beta

* #18936 source tempo: upd changelog

* #18682 source tempo: fix yaml

* #18682 source tempo: rm redundant config

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/tempo
Projects
None yet
7 participants