Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🧹 Cleanup alt attributes on images #19000

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Nov 5, 2022

What

Cleans up alt tags of image elements.

Note: I didn't touch the ones already touched in #18894

@timroes timroes requested a review from a team as a code owner November 5, 2022 00:00
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 5, 2022
<img
className={styles.webhookGuideImg}
alt={formatMessage({
id: "settings.notificationGuide.button",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This id was still used in another place, so no removal from en.json

Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, these all seem like decorative images 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants