Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🧹 Cleanup alt attributes on images #19000

Merged
merged 1 commit into from
Nov 7, 2022
Merged

🪟 🧹 Cleanup alt attributes on images #19000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-webapp/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</head>
<body>
<noscript>
<img src="%PUBLIC_URL%/logo.png" alt="logo" width="90" height="94"/>
<img src="%PUBLIC_URL%/logo.png" alt="" width="90" height="94"/>
<div class="card">
You need to enable JavaScript to run this app.
</div>
Expand Down
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/Placeholder/Placeholder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Img = styled.img<PlaceholderProps>`
`;

const Placeholder: React.FC<PlaceholderProps> = ({ resource }) => {
return <Img src={`/empty-${resource}.png`} alt="placeholder" resource={resource} />;
return <Img src={`/empty-${resource}.png`} alt="" resource={resource} />;
};

export default Placeholder;
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/common/EmptyResourceBlock/EmptyResourceBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface EmptyResourceBlockProps {
export const EmptyResourceBlock: React.FC<EmptyResourceBlockProps> = ({ text, description }) => (
<div className={styles.content}>
<div className={styles.imgBlock}>
<img src="/cactus.png" height={40} alt="cactus" />
<img src="/cactus.png" height={40} alt="" />
</div>
{text}
<div className={styles.description}>{description}</div>
Expand Down
2 changes: 1 addition & 1 deletion airbyte-webapp/src/packages/cloud/views/workspaces/WorkspacesPage/WorkspacesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const WorkspacesPage: React.FC = () => {

return (
<div className={styles.container}>
<img className={styles.logo} alt="logo" src="/cloud-main-logo.svg" width={186} />
<img className={styles.logo} alt="" src="/cloud-main-logo.svg" width={186} />
<Heading as="h1" size="lg" centered>
<FormattedMessage id="workspaces.title" />
</Heading>
Expand Down
2 changes: 1 addition & 1 deletion airbyte-webapp/src/pages/OnboardingPage/components/LetterLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const LetterLine: React.FC<LetterLineProps> = ({ onRight, exit }) => {
return (
<Line $onRight={onRight}>
<Path exit={exit} />
<Img src="/newsletter.png" alt="newsletter" width={78} height={68} exit={exit} />
<Img src="/newsletter.png" alt="" width={78} height={68} exit={exit} />
</Line>
);
};
Expand Down
16 changes: 2 additions & 14 deletions airbyte-webapp/src/pages/SettingsPage/pages/NotificationPage/components/WebHookForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,7 @@ export const WebHookForm: React.FC<WebHookFormProps> = ({ webhook }) => {
</a>
</li>
</ul>
<img
className={styles.webhookGuideImg}
alt={formatMessage({
id: "settings.notificationGuide.button",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This id was still used in another place, so no removal from en.json

})}
src={help}
/>
<img className={styles.webhookGuideImg} alt="" src={help} />
</div>
<Row className={styles.webhookUrlLabelRow}>
<Cell className={styles.webhookUrlLabelCell}>
Expand All @@ -180,13 +174,7 @@ export const WebHookForm: React.FC<WebHookFormProps> = ({ webhook }) => {
>
<FormattedMessage id="settings.notificationGuide.button" />
</Button>
<img
className={styles.webhookGuideButtonImg}
alt={formatMessage({
id: "settings.notificationGuide.button",
})}
src={help}
/>
<img className={styles.webhookGuideButtonImg} alt="" src={help} />
</>
)}
</Cell>
Expand Down