Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃獰 馃帀 Display service token validation errors in the UI #19578

Merged
merged 4 commits into from
Nov 21, 2022
Merged

馃獰 馃帀 Display service token validation errors in the UI #19578

merged 4 commits into from
Nov 21, 2022

Commits on Nov 21, 2022

  1. Display service token validation errors in the UI

    @ambirdsall
    ambirdsall committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    94e4386 View commit details
    Browse the repository at this point in the history

  2. Clean up type definitions 

    Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.
    @ambirdsall
    ambirdsall committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    3eea315 View commit details
    Browse the repository at this point in the history

  3. Disallow deleting jobs while an update is pending (#19617) 

    * Clean up type definitions

Also removes the "Error" from the `{setV,v}alidationErrorMessage`
variables to pave the way for success feedback.

* Show success message and clear form on successful dbt cloud token submission

* Always clear form error state and message in sync

* Disallow deleting jobs while an update is pending
    @ambirdsall
    ambirdsall committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    bab76fb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into alex/validate-dbt-cloud-service-tokens

    @ambirdsall
    ambirdsall committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    998b4e2 View commit details
    Browse the repository at this point in the history